Skip to content

ipc4: handler-user: bound data_off_size in vendor config get #11298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shrusti-pk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ipc4: handler-user: bound data_off_size in vendor config get #11298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ipc/ipc4/handler-user.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,6 +1142,14 @@ __cold static int ipc4_process_large_config_get(struct ipc4_message_request *ipc

/* check for vendor param first */
if (config->extension.r.large_param_id == VENDOR_CONFIG_PARAM) {
/* data_off_size is a 20-bit host-controlled field, so it can
* claim far more than the hostbox can physically hold.
*/
if (data_offset > MAILBOX_HOSTBOX_SIZE) {
ipc_cmd_err(&ipc_tr, "data_off_size %u exceeds mailbox bound",
data_offset);
return IPC4_INVALID_CONFIG_DATA_STRUCT;
}
/* For now only vendor_config case uses payload from hostbox */
dcache_invalidate_region((__sparse_force void __sparse_cache *)MAILBOX_HOSTBOX_BASE,
config->extension.r.data_off_size);
Expand Down
Loading