Repository navigation
chore!: require Python >=3.11, test 3.11–3.14 in CI - #35
Open
tkhq-valet-dev[bot] wants to merge 1 commit into
Open
tkhq-valet-dev[bot] wants to merge 1 commit into
tkhq-valet-dev[bot] wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public compatibility change (breaking)
requires-pythonchanges from>=3.8to>=3.11for turnkey-http, turnkey-sdk-types, turnkey-api-key-stamper, and the root workspace. Users on Python <3.11 cannot install new releases. A changeset is included (minor, flagged BREAKING); maintainers may prefer a major or different bump.Why
Python 3.8 (EOL 2024-10-07) and 3.10 (EOL 2026-10-01) are end-of-life. Python 3.11 is security-supported through Oct 2027; 3.12–3.14 are supported. This change is part of the CA/security runtime update effort, at Mehdi Sabraoui's direction.
Changes
requires-python >=3.11; classifiers cover 3.11–3.14; mypy targets 3.11.setup-pythondefault to 3.11.CA bundle findings
The HTTP dependency is
requests>=2.31.0, which pullscertifitransitively. The repository has no explicit certifi pin or customverify=, CA-bundle, or SSL code. No stale CA is pinned, so no CA change was made and no root was removed. Fresh installs resolve certifi 2026.10.19.Validation
Build & Testmatrix checks for Python 3.11, 3.12, 3.13, and 3.14 all pass. CI runs formatting and type checks, not pytest.ruff format --check .andmypy packages/pass on Python 3.11.2, 3.12.15, 3.13.16, and 3.14.8.TURNKEY_API_*credentials andtest_get_organization, which calls a missing client method; these failures are not caused by this change.python-dotenvis imported byhttp/tests/conftest.pybut is absent from dev dependencies; it was installed manually for local validation and was not changed here.Refactor-to-target
Mehdi's target is 500 net added lines.
git diff origin/main --shortstatreports 21 insertions and 20 deletions (net +1). The author ran the simplification pass and found no justified reductions; all changed lines support the compatibility update.Not merged.