fix(slurm): [TCL-7552] render TorchPass readiness probes - #46
Merged
sagrawal-byte merged 5 commits intoSep 24, 2026
Merged
sagrawal-byte merged 5 commits into
sagrawal-byte merged 5 commits into
Conversation
Never rm/recreate an existing FIFO, and reopen after writer EOF; the old exit-and-recreate cycle raced a respawning slurmctld into a permanently blocked fifo_open on an unlinked inode. Signed-off-by: Austin Fuller <afuller@crusoe.ai> Changelog: Fixed - Fixed cases where slurmctld would get blocked by fifo_open on an unlinked inode from logfile sidecar.
Publish the FIFO fix under new immutable image and chart versions for Helm rollout.
… sagrawal/fix-logfile-fifo
Co-authored-by: Cursor <cursoragent@cursor.com>
Broly Security ScanWarning Latest baseline snapshot is stale. Broly is running in PR-only fallback mode until the next scheduled baseline refreshes. This does not block the PR. Caution Note Re-scan this PR anytime with
|
Author
|
/broly scan |
… sagrawal/tcl-7552-torchpass-readiness Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # VERSION
Part-TimeWizard
approved these changes
Sep 24, 2026
sagrawal-byte
merged commit Sep 24, 2026
e94d426
into
slurm-1.0-together-changes
2 of 3 checks passed
3 tasks
sagrawal-byte
added a commit
that referenced
this pull request
Sep 29, 2026
The login deployment template now renders .Values.login.livenessProbe, matching the existing readinessProbe support added in #46. This lets TCCO wire a liveness probe so Kubernetes restarts the login pod when sackd or TorchPass login services die, instead of leaving the pod in a degraded state indefinitely. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bash hack/test-external-login.shhelm lint helm/slurmcontroller.slurmctld.readinessProbethrough the existing container formatterConsumed by https://github.com/togethercomputer/tcloud-charts/pull/499.
Fixes TCL-7552
Made with Cursor