Repository navigation
feat(runtime): let a project's desktop app open terminals of its own - #63
Merged
Merged
Conversation
A confined app could make no pty (terminal apps failed with posix_spawnp), and could print into every terminal the user had open. Now no app reaches a terminal unless its project says terminals: true, ticked on its add card with a warning and covered by its approval. Such a launch denies the user's ptys open at launch every way (read, write, stat, chmod, ioctl, revoke), allows new ones, and gives its shells a neutral prompt. A terminal the user opens while it runs stays exposed (stated in BACKLOG).
--desktop name=/path/App.app adds it through the Apps panel (picked, checked confined, allowed), with --desktop-arg, --files and --desktop-terminals.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 5 of the Electron targets epic: the real-app pass. First finding, fixed here.
What the minmux run found
/dev/ptmx.What changes (user decision: terminals per app, opt-in)
terminals: true: ticked on the add card, which warns what it exposes, and covered by the app's approval (a project that turns it on is asked again; the card for an app the project already names shows it).~ %): no login or Mac name on camera (user decision).--desktop,--desktop-arg,--files,--desktop-terminals.Verified
echo hello from minmux, ran it, recorded and exported; the video shows the output and the neutral prompt./code-review highrounds.Follow-ups: the VS Code pass's safe fixes in #64 (stacked on this one); clicks with DevTools open, splash timings and handover on the fixture in their own PR.