Repository navigation
Support only the Node releases the toolchain does - #3
Open
vivecuervo7 wants to merge 2 commits into
Open
vivecuervo7 wants to merge 2 commits into
vivecuervo7 wants to merge 2 commits into
Conversation
`engines` said 22.13 or later, so Node 25 looked fine until vitest's own range refused it at install. It now matches: 22.13+, 24, or 26 and up. web/.nvmrc lets fnm and nvm pick 26 on their own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nvm refuses a version that isn't installed, and 26 only became LTS last week; any 24.x satisfies `24`. Both pass the checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
enginesinweb/package.json(and the lockfile) goes from>=22.13to^22.13.0 || ^24.0.0 || >=26.0.0.web/.nvmrcwith24, fornvm useand fnm.Why
Someone on Node 25 got
EBADENGINEfromnpm install: vitest 5 supports^22.12.0 || ^24.0.0 || >=26.0.0, and with npm'sengine-stricton, that stops the install. Our>=22.13claimed 25 was fine. The range now matches, with 22.13 still the floor for the built-in SQLite..nvmrcholds a single major version, and nvm refuses one that isn't installed. 26 only became LTS on 28 October, so24(any 24.x) works for more people today. Both pass the checks in #5.🤖 Generated with Claude Code