Repository navigation
Check every PR: format, types, tests and a build - #5
Open
vivecuervo7 wants to merge 1 commit into
Open
vivecuervo7 wants to merge 1 commit into
vivecuervo7 wants to merge 1 commit into
Conversation
On each supported Node line, so a change that only works on one shows up before it reaches main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A GitHub Actions workflow,
Checks, on every PR and every push tomain. It runsnpm run lint,npm run check,npm testandnpm run buildinweb/, on Node 22, 24 and 26.Why
Now that others use Docent and changes go through PRs, each one should show it formats, type-checks, passes its tests and builds before it's merged. The three Node lines are the ones #3 says Docent supports, so a change that only works on one of them shows up here.
Once this is merged and has run, its three jobs can be made required in the
mainruleset, so a PR can't merge with them failing.🤖 Generated with Claude Code