Repository navigation
fix: zero default scalar for bytes fields in structured dtypes - #4495
Merged
d-v-b merged 2 commits intoOct 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4495 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 94 94
Lines 13619 13619
=======================================
Hits 12897 12897
Misses 722 722
🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Oct 9, 2026
Contributor
|
thanks @safaksm, I'll see if we can get this released soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structured.default_scalarbuilds each field's zero withnp.array([0], dtype)[0], which breaks for bytes fields:V(raw bytes): numpy raisesTypeError: a bytes-like object is required, not 'int', socreate_arrayfails for any struct with aVfield unlessfill_valueis passed.S(byte string): numpy returnsb"0", so unwritten chunks read back as"0".The same types outside a struct already default to zero bytes (
S4tob"",V4to four zero bytes). This PR usesnp.zeros(1, dtype)[0], which gives zero bytes for every fixed-size field.I hit this while mapping fixed-size HDF5 records (WOD plankton data) to a Zarr struct.
For reviewers
Only new struct arrays created without
fill_valuechange; stored arrays keep theirs.Author attestation
TODO
docs/user-guide/*.md(no feature change)changes/