Skip to content

Confirm perk persistence and reward receipts - #80

Draft
BenCodez wants to merge 2 commits into
vp-work/mcperks-owner-tasks-p1from
split/mcperks-p2-current78-20261029
Draft

BenCodez wants to merge 2 commits into
vp-work/mcperks-owner-tasks-p1from
split/mcperks-p2-current78-20261029

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Preserve perk state across reload and shutdown with ordered persistence, activation-credit completion and replay checkpoints.

This follow-up binds replay submission to its existing identity and cancels only the matching checkpoint reservation when admission throws. The regression fixture preserves its ledger, delayed-callback and retry assertions while supporting both known six- and eight-argument shaded dispatcher signatures.

Validation of the current candidate:

  • Full package: 315 tests passed, zero failures, errors or skips.
  • Focused replay suite: all 15 tests passed on each older and current shaded VotingPlugin test host.
  • Exact candidate SDK SHA-256: 43d10da5b3b291973aa373a5cd85a21b2c041f547e7d90454e0523f0ef420c70; current host: e85efc48a8672060a1e7764f15ab8de1ffede1ee38a4fd2acc33cf815346d452.
  • Independent two-file follow-up review: No findings.
  • JAR integrity, plugin resources, Java 21 class version and test/provided-library exclusions passed. JAR SHA-256: 68dbbb0ea46e435253add7606e05777ccaaa27fc493e2ebed3450d611309ce85.

Stacked on #78. Remains a draft pending normal dependency delivery from BenCodez/AdvancedCore#383 and outstanding native server acceptance. Candidate inputs are not released dependencies. PR #86 is the next independent feature slice; its shared fixture requires coordinated reconciliation with this update. No merge, release or deployment is included.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 641b5d96-b294-4623-a331-81b35f878a27
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant