You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mobile): the Playbook conversation form is a pushed page, so Android's picker opens - #906
On Android, the project picker in Create playbook and Prepare chat does nothing when tapped, so a person is stuck with the first project. Menu draws in the app's root window, behind an RN Modal, as in #896. The tester confirmed it on trunk (test-reports/issue-902/bf5940c831.md). Closes#902.
What changed
PlaybookConversationModal becomes a pushed settings page, PlaybookConversationScreen, with the same Menu, so there's no new picker style.
PersonaFormScreen and its helpers are renamed SettingsFormScreen, because the Playbook form now uses them too. Its wait message no longer mentions a persona.
The header's back button replaces Cancel, and Open Playbook Author and Prepare chat use the persona forms' filled button.
Leaving during a launch is refused, as the modal refused it. There's nothing unsaved to lose otherwise, so there's no discard prompt.
The thread replaces the page, so the form doesn't stay in the stack under it.
The picker sits in a pointerEvents wrapper, because Menu opens on a tap whatever its child's disabled says. So the project can't change during a launch.
On iOS, this form goes from a page sheet to a pushed page, as the persona forms did. The iOS check is at Checkpoint 3.
UI changes
Android 16, same data and theme on each light pair: before on j5/main (bf5940c831), after on df17d19b8e. Before, a tap on the picker does nothing. After, the menu opens over the form.
Before
After
After, dark
Create playbook form
Create playbook project picker tapped
Prepare chat form
Prepare chat project picker tapped
On j5/main: Prepare chat's picker doing nothing, then Create playbook with its preselected project:
base-create.mp4
Prepare chat with this PR, choosing another project:
head-prepare.mp4
Create playbook with this PR, choosing another project:
head-create.mp4
Live testing
Android: PASS at df17d19b8e (crew tester, report test-reports/pr-906/df17d19b8e.md), with the native fingerprint unchanged and one real Luna turn on each of base and head.
The picker opens in both flows and lists both projects. Choosing the non-preselected project lands in it: Prepare chat opens a draft there, and Open Playbook Author runs its turn there.
A project playbook's Prepare chat preselects that project.
Back from the form leaves with no prompt. Back during a launch shows Still working and stays. If the launch finishes first, the thread opens with that alert still up until it's dismissed.
The persona forms still guard unsaved changes after the rename.
Back from the new thread: on Android, Back from a real thread goes to the Chats list, not Settings. This isn't a regression. It's upstream's Android behaviour, and the tester confirmed the same result on base. Back from a Prepare chat draft returns to Settings › Personas.
Not exercised: an environment with no projects, which wasn't cheap with this fixture. iOS waits for Checkpoint 3, and the panel agreed.
Upstream impact
apps/mobile/src/Stack.tsx: the existing spread is renamed j5SettingsFormRoutes and gains this route, with no new lines. Recorded in FORK.md case 103 and upstreamSeams.test.ts.
This doesn't change what upstream's product does, so there's no register entry.
Checklist
One concern: the description has no "also"
Tests cover the changed behavior: no new test, since the bug is between native windows and a unit test can't see it. The tester's run is the proof, and reactCompilerCoverage compiles the new screen.
UI changes: before/after above, on Android, with videos of the flows
Live testing: the section above says what ran live and what did not
Upstream-owned files: Stack.tsx is recorded in FORK.md case 103
Upstream product: no change
Surfaces: both doors into this form are on the Playbooks section of Settings › Personas. Mobile only; web has its own.
Docs: none. docs/j5/user/playbooks.md doesn't describe this form.
Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
…oid's picker opens
Android's Menu draws behind an RN Modal, so the project picker in Create playbook
and Prepare chat did nothing, leaving a person with the first project. The form
is now a pushed settings page, as the persona forms are. Leaving during a launch
is refused, as the modal refused it, and the thread replaces the page.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
Combined panel review (reviewer-opus + reviewer-sol) at df17d19
Verdict: no findings, and the panel approves the source. Still pending: the Android run (choose a project, launch, Back) and fresh screenshots. We agree with the Captain's default of iOS at Checkpoint 3: replace to Thread is already common in upstream's mobile code, and the guard and header code is what #896's iOS run exercises.
The builder's four points
push → replace.StackActions.replace swaps only the conversation page, leaving Settings and Personas beneath it. So Back from the thread lands on Personas, the same stack as the old modal's push and close. Thread and SETTINGS_SCREENS share one stack (Stack.tsx:743, :984). allowLeaving() sets the same saved-ref bypass as a persona save, so the replayed REPLACE goes through while busy is still true. It runs only just before the dispatch, so a failed launch leaves the guard armed, busy false and the error visible.
useSettingsFormExit with hasChanges: false. It guards only during a launch, which matches the old modal's refusal to close while busy. When not busy, the page is clean and uses the native Back and swipe from #896.
The rename. The persona files change only imports and names. The helper adds only the route type, allowLeaving and the generic wait text. No references to PersonaForm* or PlaybookConversationModal remain in apps/.
pointerEvents. This is the same reason as #896: Menu opens regardless of its child's disabled, so the wrapper is what blocks the picker during a launch. On Android, the popup draws in the root portal, which is what this PR is for.
Also checked
Both doors (Create and Prepare chat) pass the environment, name and project in params.
It's an Owner page by route name (Settings*), the same as the Personas page it opens from.
FORK.md case 103, the ledger and the seams reach are updated.
Reviewer-run checks
reactCompilerCoverage.test.ts and upstreamSeams.test.ts: 1081 passed (reviewer-opus); 58 selected compiler and seams checks (reviewer-sol)
mobile vp run typecheck: exit 0 (both reviewers)
lint: clean on the changed J5 files; git diff --check: clean
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.
Walkthrough
Persona forms now use shared settings-form APIs. Playbook conversation opens from the Playbook library as a settings page, reads its parameters from navigation, and replaces its route with Thread after opening.
Changes: Mobile settings forms
Layer / File(s)
Summary
Settings-form API and persona forms apps/mobile/src/j5/agents/SettingsFormScreen.tsx, apps/mobile/src/j5/agents/AgentCreateScreen.tsx, apps/mobile/src/j5/agents/AgentEditorScreen.tsx, apps/mobile/src/j5/agents/AgentLibrarySettingsScreen.tsx
The persona-form route type, hooks, and screen are renamed to settings-form APIs. Persona create and edit screens, and agent-library navigation, use the renamed APIs. The saving alert text is generalized, and the exit hook adds allowLeaving.
The modal becomes a settings-form screen that reads navigation parameters. Opening a conversation allows leaving the form and replaces the current route with Thread. Workspace selection is disabled while busy, and the open action is disabled when busy or when no workspace is available.
The settings route set registers Playbook conversation. The Playbook library navigates to it for create and prepare actions. The settings stack and seam assertion use the renamed route factory, and the Case 103 summary includes the new route.
sequenceDiagram
participant PlaybookLibrarySettingsScreen
participant SettingsStack
participant PlaybookConversationScreen
participant Thread
PlaybookLibrarySettingsScreen->>SettingsStack: Navigate to SettingsPlaybookConversation with form parameters
SettingsStack->>PlaybookConversationScreen: Render registered route
PlaybookConversationScreen->>SettingsStack: Replace current route with Thread
SettingsStack->>Thread: Render Thread
Loading
Suggested labels:size:L
Suggested reviewers:bryantderosier
Merge Risk: Minimal · up to df17d
The form now opens as a settings page. Android picker verification remains pending, but no merge-blocking issue was established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the Playbook conversation form becomes a pushed page, which lets Android's project picker open. It also names the Android scope. The title does not mention the persona…
Linked Issues check
[#902] requires the Android playbook project picker to work in Create playbook and Prepare chat. PlaybookLibrary routes both actions to SettingsPlaybookConversation. PlaybookConversationScreen r…
Out of Scope Changes check
The changes stay within [#902]. The shared SettingsFormScreen rename, route registration, exit guard, and upstream seam update support moving the form out of the modal. The changes do not add unrela…
Description check
The description follows the repository template. It explains the problem and fix, links issue #902, includes UI evidence and videos, documents Android live testing and untested scenarios, records the …
Full details: Title check
Explanation
The title names the main change: the Playbook conversation form becomes a pushed page, which lets Android's project picker open. It also names the Android scope. The title does not mention the persona-to-settings rename or the other changes, which the description says is expected for a focused title. The title is clear and specific enough for a teammate scanning history.
Full details: Linked Issues check
Explanation
[#902] requires the Android playbook project picker to work in Create playbook and Prepare chat. PlaybookLibrary routes both actions to SettingsPlaybookConversation. PlaybookConversationScreen renders the Menu inside the pushed SettingsFormScreen, not inside an RN Modal. The screen keeps the selected project and uses it for both draft preparation and playbook launch. No linked coding requirement requires a new automated test.
Full details: Out of Scope Changes check
Explanation
The changes stay within [#902]. The shared SettingsFormScreen rename, route registration, exit guard, and upstream seam update support moving the form out of the modal. The changes do not add unrelated product behavior.
Full details: Description check
Explanation
The description follows the repository template. It explains the problem and fix, links issue #902, includes UI evidence and videos, documents Android live testing and untested scenarios, records the upstream impact, and addresses the checklist items.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
LanguageTool
FORK.md
LanguageTool checks are incomplete because the per-file request limit of 5 was reached. Remaining text was skipped; findings from completed checks are retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 effective changed lines (test files excluded in mixed PRs).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android, the project picker in Create playbook and Prepare chat does nothing when tapped, so a person is stuck with the first project.
Menudraws in the app's root window, behind an RNModal, as in #896. The tester confirmed it on trunk (test-reports/issue-902/bf5940c831.md). Closes #902.What changed
PlaybookConversationModalbecomes a pushed settings page,PlaybookConversationScreen, with the sameMenu, so there's no new picker style.PersonaFormScreenand its helpers are renamedSettingsFormScreen, because the Playbook form now uses them too. Its wait message no longer mentions a persona.pointerEventswrapper, becauseMenuopens on a tap whatever its child'sdisabledsays. So the project can't change during a launch.On iOS, this form goes from a page sheet to a pushed page, as the persona forms did. The iOS check is at Checkpoint 3.
UI changes
Android 16, same data and theme on each light pair: before on
j5/main(bf5940c831), after ondf17d19b8e. Before, a tap on the picker does nothing. After, the menu opens over the form.On
j5/main: Prepare chat's picker doing nothing, then Create playbook with its preselected project:base-create.mp4
Prepare chat with this PR, choosing another project:
head-prepare.mp4
Create playbook with this PR, choosing another project:
head-create.mp4
Live testing
Android: PASS at
df17d19b8e(crew tester, reporttest-reports/pr-906/df17d19b8e.md), with the native fingerprint unchanged and one real Luna turn on each of base and head.Back from the new thread: on Android, Back from a real thread goes to the Chats list, not Settings. This isn't a regression. It's upstream's Android behaviour, and the tester confirmed the same result on base. Back from a Prepare chat draft returns to Settings › Personas.
Not exercised: an environment with no projects, which wasn't cheap with this fixture. iOS waits for Checkpoint 3, and the panel agreed.
Upstream impact
apps/mobile/src/Stack.tsx: the existing spread is renamedj5SettingsFormRoutesand gains this route, with no new lines. Recorded in FORK.md case 103 andupstreamSeams.test.ts.This doesn't change what upstream's product does, so there's no register entry.
Checklist
reactCompilerCoveragecompiles the new screen.Stack.tsxis recorded inFORK.mdcase 103docs/j5/user/playbooks.mddoesn't describe this form.Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat builder-composer).
🤖 Generated with Claude Code