Repository navigation
Add shared entity organization, hierarchy and lifetime scripting APIs - #30
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efc834d838
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scripts need live entity organization and lifetime operations across language adapters. Add 17 shared Rust/runtime APIs for tags, groups, world-preserving hierarchy edits, subtree/delayed destruction, component presence and tag/radius queries. All SDKs call the same typed query dispatcher; editor Lua/JavaScript API hints are updated. Destroyed component owners stop receiving callbacks and release operations/signals at cleanup.
Stop/change review skips destroyed authored entities and suppresses translation-only diffs when an entity's parent differs from the original scene. Surviving entities with unchanged parents still contribute edits; restoring the authored parent makes local translations reviewable again. Structural edits remain runtime-only, avoiding wrong editor world positions and preserving normal Stop acknowledgements.
Reuse SceneWorld validated commands, generational references, transforms and the existing gameplay clock/signals/scheduler. Runtime metadata avoids a scene format migration; reparenting rejects shear instead of silently changing poses. No dependencies added. This is the first incremental entity slice of Phase 1: component mutation, prefabs/pooling, scene streaming, input/persistence and subsequent phases remain unfinished in the checked-in feature checklist.
Validation for the review fixes: all 70 engine-play tests passed, including two regression tests and a real authenticated Stop exchange after a component destroys its owner and reparents another entity. Both unit regressions were also executed against the pre-fix collector and failed as expected. Workspace/all-target compile check, engine-play Clippy with warnings denied, formatting/whitespace checks passed. Documentation lint/build/types/audit, all 34 site tests and documentation/exported-link checks passed. Existing SDK/world features remain covered by the CI suites. No Windows/macOS hardware compatibility claim.
Companion documentation: Rustic-Game-Engine/docs#31 (merged), with final validation in Rustic-Game-Engine/docs#33 (17 API pages, language examples, setup/lifetime/errors, expansion checklist; site lint/build/types/audit/tests passed).
Stop/change-review documentation fix: Rustic-Game-Engine/docs#34.
Runnable examples: Rustic-Game-Engine/examples#1.
Windows installer and all required CI passed for fix commit 68d11be: https://github.com/Rustic-Game-Engine/engine/actions/runs/38201074736. The full comprehensive scripting expansion remains unfinished.
Fresh Windows installer: https://github.com/Rustic-Game-Engine/engine/actions/runs/38201074736/artifacts/11725608597 (windows-installer, 21,661,427 bytes; the successful upload requires Engine/dist/RusticGameEngine-Setup-*.exe). Both review threads are resolved.