Repository navigation
chore(deps)(deps): bump croner from 2.2.0 to 3.0.1 - #132
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
c1c8049 to
c55b0e3
Compare
Fix for croner 4 CI breakageRoot cause: croner 3+/4 removed Change:
Dual versions: Local verification:
New head: |
c55b0e3 to
9136408
Compare
chinkan
left a comment
There was a problem hiding this comment.
TL ACCEPT at 9136408 (code review; rebase tip may move after #134).
- Shared
parse_scheduler_cron:Seconds::Required+dom_and_dow(true)+sloppy_ranges(true)— preserves 0.12-era / tcs behaviour including1/10steps - Call sites in
agent.rs+reminders.rsunified; regression pins 6-field next occurrence, rejects 5-field, keeps sloppy step - Dual croner (4.x rustfox / 3.x via tokio-cron-scheduler) is fine
Required CI green including Windows. Merge only after: (1) #134 lands and this PR is rebased clean, (2) Product GO + QA GO on PO schedule/reminder smoke (existing DB load + 1-min reminder). Do not tag.
Bumps [croner](https://github.com/hexagon/croner-rust) from 2.2.0 to 3.0.1. - [Release notes](https://github.com/hexagon/croner-rust/releases) - [Changelog](https://github.com/Hexagon/croner-rust/blob/main/CHANGELOG.md) - [Commits](Hexagon/croner-rust@v2.2.0...v3.0.1) --- updated-dependencies: - dependency-name: croner dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
croner 3+/4 removed Cron::new(...).with_seconds_*().parse() in favour of CronParser::builder(). Keep Seconds::Required + dom_and_dow(true) to match tokio-cron-scheduler, and enable sloppy_ranges(true) so shortcut step forms like 1/10 (accepted in 2.x/3.x and by tcs) still parse under croner 4's stricter OCPS defaults. Shared via parse_scheduler_cron; bump crate to 4 (tcs remains on croner 3 — dual versions in the tree).
9136408 to
a54efd1
Compare
chinkan
left a comment
There was a problem hiding this comment.
TL ACCEPT reaffirmed at rebase tip a54efd1 (on main e67250d).
Source diff unchanged vs 9136408 ACCEPT (parse_scheduler_cron + croner 4 + regressions). Merge after Product GO + QA schedule/reminder smoke + CI green. Do not tag.
Bumps croner from 2.2.0 to 3.0.1.
Release notes
Sourced from croner's releases.
... (truncated)
Changelog
Sourced from croner's changelog.
Commits
2d9085cFix issue #356e7b30dUpdate READMEcbf9ce4Bump version602d877Feature/separate interval vs fixed jobs (#33)05b94f7Implement plus-modifier for full OCPS-conformance. (#32)5820e63Fix year search (#31)0e78d79Merge pull request #30 from Hexagon/fix/ensure-7-fields-years-required7fbd4d4Ensure 7 fields when years are requiredf2aec12Merge pull request #27 from Hexagon/feature/ocps-1.4-compliancecaf7993Add --all-features to development docs. Fix serde test.