Repository navigation
(2/8) fix(runtime): roll back releases that crash right after an update - #145
Merged
Merged
Conversation
Keep the rollback request and snapshots until the new release survives a health window; an early exit restores the previous release instead of re-booting the crashing one. Boot recovery rolls back an unverified commit, discards stale requests that never matched the selection, and snapshots only the migrating stores rather than all of userdata.
Contributor
Author
|
Second up (2 of 8), right after #148. Goes early since it's the boot path. Whole stack checked, lands clean. |
This was referenced Nov 14, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A runtime that passed its update trial but crashed immediately after activation remained selected across restarts. Keep its rollback request and consistent database snapshot until it survives a 60-second serving window; an early exit or restart during that window restores the previous runtime and migrating databases. Preserve unrelated historical stores, and discard stale uncommitted requests that cannot match the saved selection.
Persist the healthy or restored decision before removing its rollback snapshot. Interrupted finalization and rollback cleanup can then resume safely after the snapshot has gone. Clear the health-window timer on early exit and shutdown, and retain the durable request as the updater mutex through terminal receipts and cleanup.
Validation:
Original runtime recovery work contributed by @0libote; maintainer review fixes add restart-safe finalization.