Repository navigation
feat(interrogate): add exposure, isolation, and upgrade lenses for SDK changes - #22
Merged
Merged
Conversation
…K changes Review bots on Lucas's MCP SDK PRs (posthog-js, posthog-python) kept finding three bug classes the gate's lenses never point at: captured data that skips redaction, state leaking between callers or instances, and default behavior that changes for users who upgrade without touching code. - blind-spots.md gains Exposure, Isolation, and Upgrade lenses. - Frame makes those three mandatory for SDK and package changes, and folds the touched directories' ADRs into the intent, so a change that reverses a recorded decision breaks the intent. - Babysit step 9 runs the correct skill once a review finding class repeats. - translation.md records both as deliberate departures. Tested: bun scripts/check-port.ts -> 0 findings.
check and threads-only touch nothing (step 6), so they offer the correct PR instead of opening it. Found by the pre-PR gate's opus adversary. Tested: bun scripts/check-port.ts -> 0 findings.
lucasheriques
marked this pull request as ready for review
November 5, 2026 19:26
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pre-PR gate should catch the bugs that review bots keep catching on SDK PRs. Across 19 MCP SDK PRs in posthog-js and posthog-python, the repeat findings fell into three classes that no lens points at: captured data that skips redaction, state leaking between callers or instances, and behavior that changes for users who upgrade without touching code.
What changed
blind-spots.mdgains Exposure, Isolation, and Upgrade lenses.Scope
Blast Radius
Every interrogate run on an SDK or package change now carries three more lenses, so adversaries spend more on those runs. Other changes are unaffected. The new rules are fork-only departures recorded in
translation.md.Verification
$session_id.checkandthreads-onlymodes would have opened a correct PR. Fixed in the second commit. A hand-run upstream sync merge kept every new line.bun scripts/check-port.tsreports 0 findings.