Repository navigation
refactor(settings): normalize state constructors (refs #2993) - #3053
Conversation
…ings_state (#2993) E2992 P40 (mechanical): add config::settings::new_settings_state(AppSettings) -> SettingsState returning the existing alias, and replace every Arc::new(RwLock::new(<AppSettings>)) construction (typed, inferred, manage() and integration tests) with it. No behavior, lock, loader or contract change. Refs #2993
|
Main advanced by the 0.45.0 release (PR #3048). The incoming delta includes Cargo.lock, package-lock.json, package.json, src-tauri/Cargo.toml and tauri.conf.json, so it affects build inputs and does not qualify for the unrelated-delta exemption. P40 remains the same approved mechanical constructor change. We will import upstream on the existing branch, keep imported release files byte-identical to main, perform a focused merge review and validate the integrated head before updating this PR. The existing head's evidence is preserved. Cancellation was requested for obsolete head4fb692ff9b32bc105b9fa04199631b7f5587e13d run38963113262. Waiting for cancellation confirmation before changing HEAD; then CI will validate the updated commit. This does not introduce a new P40 version bump or scope expansion. |
…s-owner-p40-constructors
|
|
Stale-base triage for main739162c65f31710d8b3d67803ebe8934e6e89189 versus integrated maind0f91a3d5a33edadfd3b2c0e337654f4cd5acc6f: the three incoming commits (PR #3049) change only README.md and docs/quickstart.md. The complete diff contains Markdown documentation only; no P40 source files, imports/dependencies, manifests, lockfiles, build configuration or workflows changed. This qualifies for the documented documentation-only stale-base exemption. Keep the reviewed/tested PR head0197829d8e577984d8bede2cf4556daa1a74009d and its existing CI; no branch update or fresh CI run is required for this delta. Exact local/remote head, active branch and clean worktree were verified. Local checks and merge review remain valid; remote required CI must still finish green before landing. Evidence: D:/0_repos/AgentsCommander_iac/.ac/project-shared/2992-settings-owner/minimum-path-20261016/p40-docs-only-main-delta-v1.json |
SettingsState constructors are scattered across application setup and test fixtures. This phase routes56 constructions through public new_settings_state(AppSettings), preserving the existing alias, values, cfg gates, inference, managed TypeId and application behavior. Exclusive ownership remains inactive until P50.
Closes #2993
Part of #2992, approved minimum v8/P40.
Scope:23 existing Rust files, mechanical substitutions plus the constructor; no added/deleted files, wrapper tests, IPC/DTO/frontend/dependency changes. Main's0.45.0 release was integrated without conflicts: its17 imported paths are byte-identical to upstream and the P40 patch is unchanged. PR diff against current main remains23 modified files.
Validation on 0197829 with maind0f91a3d5a33edadfd3b2c0e337654f4cd5acc6f integrated, Node22.14.0/npm11.6.2/Rust1.98.1:
All triggered and configured-required remote CI passed on this exact updated head, including Windows/Linux/macOS regression coverage; ci:full is enabled. Main’s later README/quickstart-only delta was audited under the documentation-only stale-base exemption. Existing npm audit and bundle-size output is preserved without dependency repairs in this phase.
Frozen phase: D:/0_repos/AgentsCommander_iac/.ac/plans/2992-settings-owner/P40-v8-constructors.md
Phase-SHA256: 3BA97AE75ED6D3D87C878A6C01292A46C867719596B955DD2D536357EE9EEFA7
Plan-SHA256: 05C031F312B3AA730F4D6B9528A65E3EC4E7470903CC83E923B8204D6CE4E8D2
Human approval: D:/0_repos/AgentsCommander_iac/.ac/project-shared/2992-settings-owner/minimum-path-20261016/full-r3-user-approval-v1.json
Current local check receipt: D:/0_repos/AgentsCommander_iac/.ac/project-shared/2992-settings-owner/minimum-path-20261016/p40-integrated-local-checks-accepted-v1.json
Current logs: D:/0_repos/AgentsCommander_iac/.ac/room-09-ac-dev-team-v5/room-shared/2992-P40/compiled-main-d0f91a3d/