Conversation
Co-Authored-By: GPT-6 Astra <codex@openai.com>
The new play-feature regression intentionally fails until compressed frames can be buffered ahead of a small decoded queue. Co-Authored-By: GPT-6 Astra <codex@openai.com>
This was referenced Sep 23, 2026
Collaborator
Author
|
Closing: this only carries a red regression test, and the quest now requires the play harness (which requires #3966), so nothing here can land yet. The chosen design and the repro's shape are folded into (written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a two-second playout delay, a tune-in burst fills the 30-frame decoded video queue. The decoder waits for the window to drain it and cannot observe later timestamps, leaving the playout anchor behind live.
Approach
main, recording the chosen design: buffer encoded frames through the fullmax_agewindow, decode only a few ahead, and evict the oldest decoded frame when that small queue fills.Impact
Alternatives
max_ageencoded-buffer design. Keeping raw decoded frames for a ten-second delay could retain about 900 MB at 1080p/30fps, so that partial patch was removed.Follow-ups
moq_video::decode::Consumer's encoded reader and native decoder while preserving newest-group startup, transport age bounds, discontinuity, reordered output, and tail flush. Complete the queue policy, pass the regression, and runjust check/just testbefore marking this PR ready.quest check,cargo fmt --check, andgit diff --checkpass. The focused play-feature nextest case fails as intended.(written by GPT-6 Astra)