Skip to content

fix(cpp): check release archives and OBS during dry runs - #6006

Merged
kixelated merged 4 commits into
mainfrom
quest/m1/cpp-package-check
Oct 20, 2026
Merged

fix(cpp): check release archives and OBS during dry runs#6006
kixelated merged 4 commits into
mainfrom
quest/m1/cpp-package-check

Conversation

@kixelated

@kixelated kixelated commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem

Nightly C++ dry runs skipped OBS because it depended on the tag-only publisher. The resulting C++ archives also lacked an installed-consumer check after packaging.

Approach

  • Check each packaged archive with the existing C++17, C++23, mixed-standard, pkg-config, documentation, and benchmark consumers.
  • Let OBS dry runs consume the matching checked local archive. Preserve released downloads for tag builds and explicitly gate both publishers on tags.
  • Reject missing, conflicting, or mismatched archive inputs before OBS dependency setup. Resolve check input paths from the caller's directory.
  • Wire workflow regression tests into the existing nightly tooling suite.

Impact

  • No binding, runtime API, or wire changes.
  • Build tooling adds just cpp check --archive FILE, just obs package --moq-archive FILE, and CMake MOQ_ARCHIVE_FILE.
  • No versions, tags, or publication changes beyond enforcing tag-only publication.

Alternatives

Waiting for a first release would leave this build path unchecked. Rebuilding C++ inside OBS would bypass the archive being validated.

Checks

At 9db218a70f5405d1eb49fc76342bb000a784b30d, using the pinned Nix shells and bounded build jobs:

  • just check: passed.
  • Root in-tree parity gate, nix develop .#obs --command just obs ci: passed at this exact head (formal exit 0).
  • Workflow regressions: 5 tests and 93 assertions passed. The new regression failed before the fix.
  • Native release C++ archive: built successfully.
  • Real archive through the relative-path just cpp check --archive entry point: all installed consumers passed.
  • Linux OBS package against that local release archive: compiled, linked, and archived successfully.
  • Invalid archive input checks, shellcheck, shell formatting, CMake formatting, and actionlint: passed.

The current release-link prerequisite remains uncleared. This path uses native cargo or cross GCC rather than zigbuild; the native package succeeded without a toolchain workaround.

Follow-ups

Draft pending the four-host nightly dry run. The existing OBS settings/session-report parity lane passed locally. The quest remains open until that proof is available. Full browser interop is not claimed. First publication and released-download proof remain release execution.

(written by GPT-6.1-Sol)

kixelated and others added 4 commits October 19, 2026 14:01
@kixelated
chore: claim C++ package nightly checks
ed5a543
@kixelated @codex
fix(cpp): exercise release archives and OBS in dry runs
c0fc320 
Keep publication tag-only while consuming checked local C++ archives in OBS dry runs. Reuse installed-consumer probes for the packaged archive and reject mismatched local inputs before configuring dependencies.

Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
@kixelated @codex
fix(cpp): resolve archive inputs from the caller directory
4c4ce20 
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
@kixelated @codex
style(cpp): format archive check scripts
9db218a 
Co-Authored-By: GPT-6.1-Sol <noreply@openai.com>
@kixelated

kixelated commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Checkpoint: 9db218a70f5405d1eb49fc76342bb000a784b30d, clean worktree. Exact-head just check, native release packaging, all installed archive consumers, workflow regressions, and OBS packaging against the local release archive passed.

The existing OBS settings/session-report gate is queued separately. Four-host nightly validation and release-download proof remain unrun; publication remains tag-only. Recommend /quest-iterate after the pending validation. No runtime API or wire changes.

(written by GPT-6.1-Sol)

@kixelated
kixelated marked this pull request as ready for review October 19, 2026 23:37
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6eb78c63-545c-4028-80d0-9b797a985622
📥 Commits

Reviewing files that changed from the base of the PR and between 25532ea and 9db218a.

📒 Files selected for processing: 10
  • .github/justfile
  • .github/workflows/release-cpp.yml
  • cpp/justfile
  • cpp/moq/README.md
  • cpp/obs/CMakeLists.txt
  • cpp/obs/README.md
  • cpp/obs/build.sh
  • sh/cpp/check.sh
  • sh/gh/cpp.test.ts
  • sh/obs/check.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T23:47:29.500854Z 9db218a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 351fb13 Oct 20, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m1/cpp-package-check branch October 20, 2026 00:54
kixelated added a commit that referenced this pull request Oct 20, 2026
@kixelated @claude
quest(m1): record what remains of the C++ package proof after #6006
ce2d3ec 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
Merged
Merged
kixelated added a commit that referenced this pull request Oct 21, 2026
@kixelated @claude
quest(m1): finish the C++ and OBS nightly package proof
b93d5b0 
The first scheduled Nightly after #6006 checked all four packaged C++
archives and built both OBS plugins against them, and the Linux OBS lane
passed. Record the proof in the first C++ release quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated mentioned this pull request Oct 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kixelated