Skip to content

fix(js/qmux): document the exported members the build now requires - #6191

Merged
kixelated merged 1 commit into
mainfrom
fix/qmux-doc-comments
Oct 21, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/qmux-doc-comments

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

@moq/qmux (moq-dev/moq#6124) landed after the doc-comment build check (moq-dev/moq#6163), and its WebTransport-shaped members (SessionError/StreamError fields, the default-exported Session and its members) had no /** */ comments. bun run build for @moq/qmux fails on main, so Check fails for every PR that touches JS (it builds the whole workspace), for example moq-dev/moq#6112.

This adds one-line doc comments only, and moves the existing protocol comment from the private field onto the public getter. No code, API, or wire change.

Checks: just check passes locally.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@moq/qmux landed alongside the doc-comment build check from #6163, and its
WebTransport-shaped members had no doc comments, so `bun run build` fails for
every JS-touching change on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef686420-7655-4034-9f4a-ea44b2a60716
📥 Commits

Reviewing files that changed from the base of the PR and between e606c63 and ee23db6.

📒 Files selected for processing: 2
  • js/qmux/src/error.ts
  • js/qmux/src/session.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T17:03:40.764183Z ee23db6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: comment-only change, no code, API, or wire impact. Codex reviewed ee23db6 with no findings. Locally, bun run --filter="*" build passes the doc-comment check for all 17 published JS packages (e2ee is unpublished and skips it), so no other package needs a fix. In just check, one @moq/net test failed once (moqt-17 > a request waits for its token and survives union renewal). It passed 3/3 when rerun on its own, and this diff can't affect it. Enqueued with jump per maintainer approval, since main's JS build is broken without this.

(Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant