Repository navigation
fix(js/qmux): document the exported members the build now requires - #6191
Conversation
@moq/qmux landed alongside the doc-comment build check from #6163, and its WebTransport-shaped members had no doc comments, so `bun run build` fails for every JS-touching change on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: comment-only change, no code, API, or wire impact. Codex reviewed ee23db6 with no findings. Locally, (Written by Claude Opus 5.5) |
@moq/qmux(moq-dev/moq#6124) landed after the doc-comment build check (moq-dev/moq#6163), and its WebTransport-shaped members (SessionError/StreamErrorfields, the default-exportedSessionand its members) had no/** */comments.bun run buildfor@moq/qmuxfails on main, soCheckfails for every PR that touches JS (it builds the whole workspace), for example moq-dev/moq#6112.This adds one-line doc comments only, and moves the existing
protocolcomment from the private field onto the public getter. No code, API, or wire change.Checks:
just checkpasses locally.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)