Skip to content

ci: run merge queue tests with 24 workers - #6290

Merged
kixelated merged 5 commits into
mainfrom
quest/m1/ci-housekeeping
Oct 22, 2026
Merged

kixelated merged 5 commits into
mainfrom
quest/m1/ci-housekeeping

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The merge queue spends many test slots waiting, but earlier loaded validation at 24 workers exposed a redundant-importer failure and a late-stats readiness failure. The importer fix has now landed in moq-dev/moq#6113. The stats test also inherited RUST_LOG=warn while waiting for an INFO message, so normal retention expiry looked like an early exit.

Approach

Pin RUST_LOG=info only on the readiness-dependent stats child, matching existing CLI fixtures. After three clean loaded full Rust passes, export NEXTEST_TEST_THREADS=24 only in the merge-group Check step. Keep the existing io-uring test-group limit.

Rewrite the retained quest to its remaining actionlint publication condition.

Impact

  • Public API and wire: none.
  • Merge-group tests use 24 workers. Release PR jobs retain their default worker selection.
  • Test subprocess logging only; production logging, assertions, retries and timeouts are unchanged.

Alternatives

A job-wide worker setting would also change release PRs. A conditional export scopes the setting to the queue. Clearing logging for every CLI child would hide requested diagnostics; override only the child whose readiness depends on its log.

Validation

  • Initial main baseline 005eca0: the late sink fails in 10.1 seconds with inherited RUST_LOG=warn. The patched four stats tests pass with inherited RUST_LOG=off, including the late sink in 140 ms. Earlier full CLI checks passed 190 tests with 15 nightly tests skipped.
  • New loaded validation includes main 2d36911 and the merged importer fix. All three full-workspace Rust passes use 24 workers pinned to CPUs 0-7: each reports 9,435 passes and 59 skips, in 35.765, 35.784 and 35.767 seconds. The third uses MOQ_STRICT=1 and NEXTEST_PROFILE=ci. No failed pass was retried to obtain these results.
  • The loaded just check --all pass completed language, binding and consumer checks through OBS, then stopped at the Nix runner-image build: this host refuses unshare writing /proc/self/uid_map. Rust tests were therefore continued directly as described above.
  • Required final just ci passed selected Rust lint/docs, quest and drill checks, then hit the same unchanged Nix host restriction. Full CI is not claimed green.
  • Independent just gh check, Markdown, shell, TOML and Just formatting checks pass. quest check --base origin/main passes 458 documents. Diff whitespace passes.
  • Actionlint still reports 1.7.12.

Remaining

Unfinished outside condition: retain the queue-key ignore until an actionlint release supporting queue reaches the dev shell and just gh check accepts queue: max without it. The retained quest now contains only that work. Queue concurrency validation is complete.

Follow-ups

No new quest or duplicate importer fix. The existing housekeeping quest retains the actionlint condition.

(Written by GPT-6)

@kixelated kixelated changed the title Finish CI housekeeping test(cli): isolate the late-stats readiness log filter Oct 22, 2026
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Checkpoint 22ba550 is pushed. The baseline late-stats failure is an inherited log-filter issue: RUST_LOG=warn hid the INFO readiness event. The child that consumes that event now explicitly uses info, matching the other log-driven fixtures. The existing four stats tests pass under inherited RUST_LOG=off, and the complete CLI package checks pass 190 tests under inherited warn (15 existing nightly tests skipped). No production behavior or assertion/timeout changes.

The quest and ## Decisions needed retain the unfinished conditions: account for moq-dev/moq#6113, then complete loaded validation before enabling 24 threads; actionlint is still 1.7.12, so keep its queue-key ignore. Neither setting changed. Full just ci remains limited by the unchanged runner-image unshare uid_map host restriction after Rust lint, quest, and drill checks passed.

(Written by GPT-6)

@kixelated kixelated changed the title test(cli): isolate the late-stats readiness log filter ci: run merge queue tests with 24 workers Oct 22, 2026
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 20:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T20:43:52.236652Z 8620179 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4de798c3-c05b-49f8-9c61-128ff2a7d5bf
📥 Commits

Reviewing files that changed from the base of the PR and between 2d36911 and 8620179.

📒 Files selected for processing: 3
  • .github/workflows/check.yml
  • quest/m1/ci-housekeeping.md
  • rs/moq-cli/tests/integration/stats.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 9f3174f Oct 22, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m1/ci-housekeeping branch October 22, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant