Repository navigation
Conversation
Quest-Claim: c2fbdc40c41c001e
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Maintainer decision, 2026-11-01: hold this PR until rust2 has one moq pin again, once TypeScript can move to moq's main (quest (written by Claude Opus 5.5) |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
moq-clock's items exported under the bare prefix:
now()andorigin()weremoq_nowandmoq_origin, which read like moq-net's origin types. moq has since moved moq-clock intokio::clock(moq-dev/moq#7027), andrs/moq-clockis gone from moq'smain.Approach
947c91d0, which haskio::clock, and export kio's clock in moq-clock's place: the rule names its itemsmoq_clock_*.moq_revinffi/justfile;just ts's stays where it is (see Decisions needed). ts'smoq-pintakes the revision.947c91d0is the last commit before fix(net): take a reserved group without asking its cursor again moq#7032, past which moq-tokio'sSendcheck overflows the recursion limit thatjust ffi moqdenies.clock::wallismoq_clock_now_wallandclock::intervalismoq_clock_interval_every.Clockheldmoq_clock, so itsnowandwallclashed with the clock's. It is renamed tomoq_mux_clock, beside moq-mux's othermux_*renames.just ffi census. moq.c, moq.cpp, and moq.kt follow moq-net's renames (path::Error,origin::Consumer::request).Checks:
just ffi moq(C, C++, Kotlin against the export) passes; the bench's export.c, export.cpp, and export.kt build against the new header.Impact
ffi/MIGRATE.md:moq_nowismoq_clock_now(C++moq::clock_now, KotlinclockNow), and each of moq-clock's items moves undermoq_clock_. moq-mux'sClockismoq_mux_clock. moq-net's upstream renames follow.Alternatives
just tsandjust ffishare. moq dropped moq-wasm in chore!: remove WASM support moq#7475, which picked the browser's randomness for moq-net on wasm32, sojust ts moqandjust ts censusfail to build getrandom and uuid past it.main:just ffi moqfails on the recursion limit lint above.clock::nowandclock::wallinstead of moq-mux'sClock:moq_clock_nowis the clock's natural name, and moq-mux's type is the one that borrows the namespace.Follow-ups
Decisions needed
ClockC name.moq_mux_clock, withTIMESCALEasmoq_mux_clock_fixed_timescale.moq_media_clock.moq_clockfor moq-mux and rename kio's clashing functions instead.Review
Round 1:
quest review, Codex gpt-6.1-sol at medium effort, on headee324f6d: no findings. Head48fd8e12adds only a conflict-free merge ofmain.just cipasses on48fd8e12, andjust ffi moqpasses onee324f6d.🤖 Generated with Claude Code