Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Close the gap between PuppetControl's 25-frame non-uniform parameter sweep and what an actual 30 FPS video displays. Provide real timed-playback evidence, rather than continuing to add unverified global fade/opacity variants.
Draft stacked PR on
feat/eye-transition-no-ghost(#13), which is itself built on #12/#11/#10/#9. Do not merge directly intomain.Changes
character qa blink <imported-project> --timed [--region x,y,w,h]retains full source/model/provenance validation and does not change artwork or approval.n/30exactly. Synthetic schedule: 250 ms open lead-in, 140 ms close, 65 ms hold, 240 ms reopen and open tail.docs/EYE_TIMING.md, README/agent-skill guidance, and a tiny MIT-licensed Hana 30fps sample MP4 attributed in third-party notices.Actual visual findings
Validation
npm run verify: 220 passed tests across 38 files, TypeScript check/build passed.git diff --checkclean; only MIT-licensed attributed tiny video is committed, no user art, private recordings, or generated rig snapshot.character qa blink25-frame threshold inspection unchanged.Remaining blockers
approved:false.