Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make real progress toward continuous Live2D-like eyelid motion for a provenance-tracked single-image import. The previous raster lash warps formed exaggerated triangular corners and the drawn eye-sprite fades ghosted/doubled entire eyes.
This is a draft stacked PR targeting
feat/timed-blink-qa(#14), which depends on draft #13 → #12 → #11 → #10 → #9. Do not independently merge into main.Implementation
EyeLOpenandEyeROpen.character eyes vectorize <project-dir> --experimental. Verifies original source/spec/model/textures SHA-256 first, revokes existing approval before any derived asset write, validates with the pinned Rev2D engine, creates an additional uniquely named model, writes a fresh provenance record and updates the manifest. Original PNG, texture images, existing model and drawn-eye files stay intact; approval is always false on output.docs/VECTOR_EYELIDS.md, agent workflow, roadmap and MIT sample attribution.Actual visual result
Watch 1.2s/30fps vector-eyelid blink
EyeOpen=0.3/0.14. The derived vector strips follow the existing smooth curved occlusion mask and join at a clean closed line. No full-eye opacity blending is involved in the derived model. The style is simpler and not artist-approved.AngleX=±8,EyeBallX=±0.2,EyeOpen=0.35). Inspected actual pixels. Other art styles, detailed lashes and speaker video remain untested.character eyes vectorizeagainst a separate ignored imported Hana project copy. Source→new rig SHA-256 verification passed; realcharacter inspectconfirmsapproved:false. A second disposable copy with QA-ONLY artificial approval verified that the operation revokes prior approval and leaves the new rig unapproved.scene new→scene validate→scene renderproduced a real 3.000s H.264 MP4 at 512×640, 30 FPS, 90 frames, passed FFprobe checker and actual 0/1/2s frames were visually inspected. Source rig never marked approved.Tests
npm run verify: 225 passing tests across 39 files, TypeScript typecheck and build passed.git diff --checkclean. Tiny attributed sample video/image included; all generated full models and private temp projects remain ignored.Limitations / review gate
The vector stroke differs from original hand-painted eyelashes, can lose lashes/texture character, and may not work on 3/4 art or heavily occluded eyes. This is one MIT-licensed character, not proof of universal polished conversion. No automatic approval. Existing upstream
avatar posesoutput from the original model may be outdated after vectorization; use this command's new derived-model blink QA and inspect head/gaze. Rebuilding restores original source rig; keep an independent backup before testing.Keep this PR and the upstream stack draft until multi-style visual review, editability and release safety are evaluated.