Repository navigation
[perf] Replace per-node config scan with keyed lookup in Rename func/const/string rules - #8736
Merged
Merged
Conversation
…const/string rules RenameFunctionRector, RenameConstantRector and RenameStringRector each held a map already keyed by the matched value, yet scanned the whole map per visited node (isStringName/isName/isValue per entry). Resolve the node name/value once and look the rename up directly. - function: keyed by lowercased name (function names are case-insensitive), preserved. - constant: case-sensitive direct lookup, matching PHP constant semantics. - string: resolve the value once, then array lookup. bench/rename_function_keyed_lookup_bench.php (500 renames, 200 non-matching calls): 173.1 -> 3.3 us/call.
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #8734 / #8735. Three more configurable Renaming rules held a map already keyed by the value they match, yet scanned the whole map for every visited node.
RenameFunctionRectorisStringName()per entry over all func callsRenameConstantRectorisName()per entry over all const fetchesRenameStringRectorisValue()per entry over all string literalsThese nodes (func calls, const fetches, string literals) are high frequency and upgrade sets configure hundreds of entries, so the per-node scan was a real linear cost.
Behaviour
Covered by the existing rule tests (all green). Note: the constant lookup is now case-sensitive, which is correct for PHP constants and consistent with how the rename writes the new name; the function lookup stays case-insensitive via lowercased keys.
Numbers
bench/rename_function_keyed_lookup_bench.php(500 renames, 200 non-matching calls, CPU time):Scales with configured-map size. Full
rules-tests/Renaminggreen, PHPStan and ECS clean.