Repository navigation
Cleanup: Remove path_matches and value_str from AttributeExt - #165869
Merged
Merged
Conversation
Collaborator
|
cc @rust-lang/clippy Some changes occurred in compiler/rustc_attr_ir |
rustbot
added
A-attributes
rustbot
added
T-clippy
ada4a
reviewed
Nov 12, 2026
Contributor
There was a problem hiding this comment.
I wonder what the motivation for this change is. Removing AttributeExt in the long term?
Might as well take over the review ig: r? @ada4a
Member
Author
|
The goal is:
@rustbot ready |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
attr-ext2
branch
from
November 12, 2026 19:04
818020a to
60a3d26
Compare
JonathanBrouwer
force-pushed
the
attr-ext2
branch
from
November 12, 2026 19:07
60a3d26 to
a3ee392
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
uhhh, will this work? @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 13, 2026
Cleanup: Remove `path_matches` and `value_str` from `AttributeExt` Should not change observable behaviour. Every commit passes tests, so can be reviewed commit by commit if desired. Since this feels more like clippy changes than rustc changes r? clippy
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
…uwer Rollup of 18 pull requests Successful merges: - #164828 (When suggesting path of renamed crate, use the renamed name) - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch) - #165068 (Change color usage for highlights) - #165221 (Canonicalize more comparison operators) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165745 (Don't ICE when a guard condition is a place of type `!`) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) - #165905 (CI: Use a consistent locale when sorting docker build inputs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
…uwer Rollup of 17 pull requests Successful merges: - #164828 (When suggesting path of renamed crate, use the renamed name) - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch) - #165068 (Change color usage for highlights) - #165221 (Canonicalize more comparison operators) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) - #165905 (CI: Use a consistent locale when sorting docker build inputs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 13, 2026
Rollup merge of #165869 - JonathanBrouwer:attr-ext2, r=ada4a Cleanup: Remove `path_matches` and `value_str` from `AttributeExt` Should not change observable behaviour. Every commit passes tests, so can be reviewed commit by commit if desired. Since this feels more like clippy changes than rustc changes r? clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not change observable behaviour.
Every commit passes tests, so can be reviewed commit by commit if desired.
Since this feels more like clippy changes than rustc changes
r? clippy