Repository navigation
Rollup of 17 pull requests - #165918
Merged
Merged
Rollup of 17 pull requests#165918
Conversation
```
error[E0599]: no associated function or constant named `bar` found for struct `Foo` in the current scope
--> src/main.rs:3:15
|
3 | let a = Foo::bar();
| ^^^ associated function or constant not found in `Foo`
|
= help: items from traits can only be used if the trait is in scope
help: trait `Bar` which provides `bar` is implemented but not in scope; perhaps you want to import it
|
1 + use some_inner_lib_rename::Bar;
|
```
instead of
```
error[E0599]: no associated function or constant named `bar` found for struct `Foo` in the current scope
--> src/main.rs:3:15
|
3 | let a = Foo::bar();
| ^^^ associated function or constant not found in `Foo`
|
= help: items from traits can only be used if the trait is in scope
help: trait `Bar` which provides `bar` is implemented but not in scope; perhaps you want to import it
|
1 + use some_inner_lib::Bar;
|
```
where crate `some_inner_lib` is in `Cargo.toml` as `some-inner-lib-rename = { package = "some-inner-lib" }`, making `some_inner_lib` inaccessible in the local crate.
…canonical" in diagnostics
after some discussion, we decided we want view types to be `!Sized`, at least at the beginning. this commit updates the test suite so that view types are not passed by value anymore.
this commit is quite big because we want to always exhaustively match on all the `TyKind` variants. none of the `unimplemented!()` is reachable because we don't *actually* lower view types (yet!).
/!\ the test suite is has not been updated /!\ the `unreachable!()`s added previously are suddenly reached, triggering literally all the view types test suite to ICE. this is fixed by the next commit.
By default, we optimize cargo and thus need to run the stage2 PGO-instrumented cargo binary to get its profiles. When we opt out of that, we don't have a stage2 cargo, and don't need it, so we just use the regular stage0 cargo there.
Contributor
rust-bors
Bot
removed
the
S-waiting-on-bors
This was referenced Nov 13, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d362215 (parent) -> 80196be (this PR) Test differencesShow 224 test diffsStage 1
Stage 2
Additionally, 138 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 80196be0e787008b6fb14d2990aba92083cd68e1 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Nov 13, 2026
Collaborator
|
Finished benchmarking commit (80196be): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.2%, secondary 1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.4%, secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 483.169s -> 489.761s (1.36%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: d3622156fd In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
Member
Author
|
@rust-timer triage all |
Collaborator
Running triage with 17 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#164828 2ac6be9 When suggesting path of renamed crate, use the renamed nameInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #164864 e5e8fa4 Avoid hoisting uninitialized reads in EarlyOtherwiseBranchInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 28.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. #165068 18152f9 Change color usage for highlightsInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. #165221 756fc62 Canonicalize more comparison operatorsInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #165841 0844387 Tell Miri about the alignment handling in the Windows System allocatorQueued 0844387 with parent d362215, future comparison URL. #165869 223b2a8 Cleanup: Remove
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -1.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.6% | [-1.6%, -1.6%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
3.8% | [3.8%, 3.8%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This perf run didn't have relevant results for this metric.
#165565 885e31b view-types: lower view types from HIR
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.2% | [0.2%, 0.3%] | 2 |
| Regressions ❌ (secondary) |
0.2% | [0.1%, 0.3%] | 26 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.2% | [-0.2%, -0.2%] | 1 |
| All ❌✅ (primary) | 0.2% | [0.2%, 0.3%] | 2 |
Max RSS (memory usage)
Results (secondary -1.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.8% | [-1.8%, -1.8%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165622 3c332e8 small cleanups in rustc_codegen_llvm
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.3% | [0.2%, 0.5%] | 5 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165771 fed5ec2 tests: cover MSVC ThinLTO exported symbol preservation
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -1.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.8% | [-2.0%, -1.6%] | 3 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165810 9b241af reflection: reflect attributes from adts, fields, and variants
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.2%] | 4 |
| Improvements ✅ (secondary) |
-0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 4 |
Max RSS (memory usage)
Results (secondary -2.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-2.0% | [-2.0%, -2.0%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165823 ae82133 Tweak crate error wording and turn them into fatal errors
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-0.3% | [-0.3%, -0.3%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -2.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-2.0% | [-2.0%, -2.0%] | 3 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165849 56f05b6 More opt-dist improvements
Queued 56f05b6 with parent d362215, future comparison URL.
There are currently 11 preceding artifacts in the queue.
It will probably take at least ~2.7 hours until the benchmark run finishes.
#165855 7e6fbf5 Update sysinfo version to 0.40.3
Queued 7e6fbf5 with parent d362215, future comparison URL.
There are currently 12 preceding artifacts in the queue.
It will probably take at least ~2.9 hours until the benchmark run finishes.
#165872 1c1aa3f Some attribute related cleanups
Queued 1c1aa3f with parent d362215, future comparison URL.
There are currently 14 preceding artifacts in the queue.
It will probably take at least ~3.4 hours until the benchmark run finishes.
#165905 46f1cc7 CI: Use a consistent locale when sorting docker build inputs
Queued 46f1cc7 with parent d362215, future comparison URL.
There are currently 16 preceding artifacts in the queue.
It will probably take at least ~3.9 hours until the benchmark run finishes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
path_matchesandvalue_strfromAttributeExt#165869 (Cleanup: Removepath_matchesandvalue_strfromAttributeExt)BackendRepr::MemorywithPassMode::Direct#165880 (Remove dead code for returningBackendRepr::MemorywithPassMode::Direct)-Zllvm-tpdeflag torustc_codegen_llvm#164108 (Add unstable-Zllvm-tpdeflag torustc_codegen_llvm)sysinfoversion to0.40.3#165855 (Updatesysinfoversion to0.40.3)r? @ghost
Create a similar rollup