Repository navigation
Bump go-ethereum in gethwrappers/helpers - #572
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
jmank88,
kalverra and
matYang
October 9, 2026 19:45
Contributor
|
👋 ibrajer, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency versions and checksums are consistent with the intended module alignment.
0 open findings
What changed in this PR
Aligns the helpers module with the root module’s go-ethereum version as preparation for wrapper regeneration.
Changes:
- Bumps go-ethereum to v1.17.4.
- Updates
x/toolsand dependency checksums.
| File | Description |
|---|---|
gethwrappers/helpers/go.mod |
Updates direct dependency versions. |
gethwrappers/helpers/go.sum |
Records corresponding checksums. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
📊 API Diff Results
|
jmank88
reviewed
Oct 9, 2026
|
|
||
| require ( | ||
| github.com/ethereum/go-ethereum v1.17.3 | ||
| github.com/ethereum/go-ethereum v1.17.4 |
Collaborator
There was a problem hiding this comment.
Should we go to latest patch, 1.17.8?
jmank88
previously approved these changes
Oct 9, 2026
ibrajer
changed the title
pavel-raykov
approved these changes
Oct 12, 2026
cll-dawid
approved these changes
Oct 12, 2026
ibrajer
added a commit
that referenced
this pull request
Oct 28, 2026
ibrajer
added a commit
that referenced
this pull request
Oct 28, 2026
The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing wrapper generation to fail with an abigen version mismatch in CI.
ibrajer
added a commit
that referenced
this pull request
Oct 28, 2026
The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing the wrapper generation to fail with an abigen version mismatch (expected 1.17.3, installed 1.17.4) in CI. Co-Authored-By: Claude Code <noreply@anthropic.com>
Merged
ibrajer
added a commit
that referenced
this pull request
Oct 29, 2026
* Remove VRF v1 contracts, wrappers and txmgr transmit checker Deletes the VRF v1 consumer-side contracts (VRFConsumerBase, VRFRequestIDBase, VRFCoordinatorMock and v1 test consumers/helpers), their generated Go wrappers, the VRFV1 transmit checker in pkg/txmgr, and the corresponding wrapper generation and compile script entries. VRF v2 and VRF v2 Plus are unaffected and will be removed separately. Co-Authored-By: Claude Code <noreply@anthropic.com> * Bump go-ethereum to v1.17.4 in contracts/cre/gobindings The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing the wrapper generation to fail with an abigen version mismatch (expected 1.17.3, installed 1.17.4) in CI. Co-Authored-By: Claude Code <noreply@anthropic.com> * Remove VRF v1 contracts from compile script The v1 removal commit missed these entries, causing forge to fail with 'No source files found' for the deleted contracts. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update GETH_VERSION to 1.17.4 in CRE gobindings versions files Wrapper regeneration updates these files to match the go-ethereum version in contracts/cre/gobindings/go.mod (bumped to v1.17.4 earlier in this PR), so they must be committed for the wrapper validation to pass. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com>
ibrajer
added a commit
that referenced
this pull request
Oct 29, 2026
* Remove VRF v2 contracts Deletes the VRF v2 Solidity contracts (VRFCoordinatorV2, VRFConsumerBaseV2, VRFV2Wrapper, consumers, test helpers, mocks and the AuthorizedReceiver, KeepersVRFConsumer, VRFOwner and VRFSubscriptionBalanceMonitor contracts that depend on the v2 coordinator interface) and removes their compile script entries. Also removes the corresponding go:generate directives and wrapper dependency-version entries (identical to the change in the VRF v2 wrappers removal PR, so the two can merge in either order). Co-Authored-By: Claude Code <noreply@anthropic.com> * Remove stale IAuthorizedReceiver entry from compile script The contract was deleted in this branch but its compile entry was missed, causing forge to fail with 'No source files found' and the wrapper generation verification to panic. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update GETH_VERSION to 1.17.4 in CRE gobindings versions files Wrapper regeneration updates these files to match the go-ethereum version in contracts/cre/gobindings/go.mod (bumped to v1.17.4 earlier in this PR), so they must be committed for the wrapper validation to pass. Co-Authored-By: Claude Code <noreply@anthropic.com> * Bump go-ethereum to v1.17.4 in contracts/cre/gobindings The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing the wrapper generation to fail with an abigen version mismatch in CI. Same change as in #571. Co-Authored-By: Claude Code <noreply@anthropic.com> * Remove stale VRF v1 entries from native_solc_compile_all_vrf The VRF v1 removal (#571) deleted these Solidity sources, but the compile script still referenced them, causing forge build to fail with "No source files found in specified build paths" in CI. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to unblock the following draft PR: #571
Aligns the helpers module with the root module's
go-ethereumversion (v1.17.4, bumped in #559). The version skew causedbuild_abigento silently skip building abigen, breakingmake abigenand theNative Compilation / wrapper-result-validationCI checks.Note that
gethwrappers/go.modstill requires the published helpers version; a follow-up PR must bump it (plus geth itself) and regenerate all wrappers.