Repository navigation
VRF v1 removal - #571
Merged
Merged
VRF v1 removal#571
Conversation
Contributor
|
Contributor
|
Contributor
📊 API Diff Results
|
Deletes the VRF v1 consumer-side contracts (VRFConsumerBase, VRFRequestIDBase, VRFCoordinatorMock and v1 test consumers/helpers), their generated Go wrappers, the VRFV1 transmit checker in pkg/txmgr, and the corresponding wrapper generation and compile script entries. VRF v2 and VRF v2 Plus are unaffected and will be removed separately. Co-Authored-By: Claude Code <noreply@anthropic.com>
The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing the wrapper generation to fail with an abigen version mismatch (expected 1.17.3, installed 1.17.4) in CI. Co-Authored-By: Claude Code <noreply@anthropic.com>
ibrajer
force-pushed
the
vrf-v2-removal
branch
from
October 28, 2026 15:50
2f45701 to
c9abee3
Compare
The v1 removal commit missed these entries, causing forge to fail with 'No source files found' for the deleted contracts. Co-Authored-By: Claude Code <noreply@anthropic.com>
Wrapper regeneration updates these files to match the go-ethereum version in contracts/cre/gobindings/go.mod (bumped to v1.17.4 earlier in this PR), so they must be committed for the wrapper validation to pass. Co-Authored-By: Claude Code <noreply@anthropic.com>
ibrajer
marked this pull request as ready for review
October 28, 2026 20:58
product-security-plaid-production
Bot
requested review from
MStreet3,
bolekk,
ilija42,
matYang and
timothyF95
October 28, 2026 20:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the removal of legacy VRF v1 support.
No open issues 🎉
What changed in this PR
Removes legacy VRF v1 support from the EVM contracts, generated Go bindings, and transaction manager, while leaving VRF v2 removal for a separate PR.
Changes:
- Deletes VRF v1 contracts, helpers, mocks, and generated bindings.
- Removes the VRF v1 transmit checker and its tests, plus obsolete compilation and generation entries.
- Aligns CRE bindings with go-ethereum v1.17.4 to address the reported abigen version mismatch.
| File | Description |
|---|---|
pkg/txmgr/transmitchecker.go |
Removes the VRF v1 checker and factory case. |
pkg/txmgr/transmitchecker_test.go |
Removes VRF v1 checker tests. |
pkg/txmgr/models.go |
Removes the VRF v1 checker type constant. |
gethwrappers/go_generate_vrf.go |
Removes VRF v1 generation directives. |
gethwrappers/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Removes deleted wrapper dependency records. |
gethwrappers/generated/vrf_ownerless_consumer_example/vrf_ownerless_consumer_example.go |
Deletes ownerless consumer bindings. |
gethwrappers/generated/vrf_load_test_ownerless_consumer/vrf_load_test_ownerless_consumer.go |
Deletes ownerless load-test bindings. |
gethwrappers/generated/vrf_coordinator_mock/vrf_coordinator_mock.go |
Deletes v1 coordinator mock bindings. |
gethwrappers/generated/solidity_vrf_wrapper/solidity_vrf_wrapper.go |
Deletes legacy VRF bindings. |
gethwrappers/generated/solidity_vrf_request_id/solidity_vrf_request_id.go |
Deletes legacy request-ID helper bindings. |
gethwrappers/generated/solidity_vrf_request_id_v08/solidity_vrf_request_id_v08.go |
Deletes Solidity 0.8 request-ID helper bindings. |
gethwrappers/generated/solidity_vrf_coordinator_interface/solidity_vrf_coordinator_interface.go |
Deletes v1 coordinator bindings. |
gethwrappers/generated/solidity_vrf_consumer_interface/solidity_vrf_consumer_interface.go |
Deletes legacy consumer bindings. |
gethwrappers/generated/solidity_vrf_consumer_interface_v08/solidity_vrf_consumer_interface_v08.go |
Deletes Solidity 0.8 v1 consumer bindings. |
contracts/src/v0.8/vrf/VRFRequestIDBase.sol |
Deletes v1 request-ID generation logic. |
contracts/src/v0.8/vrf/VRFConsumerBase.sol |
Deletes the v1 consumer base contract. |
contracts/src/v0.8/vrf/testhelpers/VRFRequestIDBaseTestHelper.sol |
Deletes the request-ID test helper. |
contracts/src/v0.8/vrf/testhelpers/VRFOwnerlessConsumerExample.sol |
Deletes the v1 ownerless consumer example. |
contracts/src/v0.8/vrf/testhelpers/VRFLoadTestOwnerlessConsumer.sol |
Deletes the v1 load-test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFConsumer.sol |
Deletes the v1 test consumer. |
contracts/src/v0.8/vrf/mocks/VRFCoordinatorMock.sol |
Deletes the v1 coordinator mock. |
contracts/scripts/native_solc_compile_all_vrf |
Removes compilation entries for deleted contracts. |
contracts/cre/gobindings/v2/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Updates the recorded geth version to 1.17.4. |
contracts/cre/gobindings/v1/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Updates the recorded geth version to 1.17.4. |
contracts/cre/gobindings/go.sum |
Refreshes dependency checksums for the upgrade. |
contracts/cre/gobindings/go.mod |
Bumps go-ethereum and adjusts indirect dependencies. |
contracts/cre/gobindings/dev/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Updates the recorded geth version to 1.17.4. |
Review effort: Balanced
wentzeld
approved these changes
Oct 28, 2026
bolekk
approved these changes
Oct 28, 2026
jmank88
approved these changes
Oct 28, 2026
leeyikjiun
approved these changes
Oct 29, 2026
RayXpub
approved these changes
Oct 29, 2026
ilija42
approved these changes
Oct 29, 2026
ibrajer
added a commit
that referenced
this pull request
Oct 29, 2026
The VRF v1 removal (#571) deleted these Solidity sources, but the compile script still referenced them, causing forge build to fail with "No source files found in specified build paths" in CI. Co-Authored-By: Claude Code <noreply@anthropic.com>
ibrajer
added a commit
that referenced
this pull request
Oct 29, 2026
* Remove VRF v2 contracts Deletes the VRF v2 Solidity contracts (VRFCoordinatorV2, VRFConsumerBaseV2, VRFV2Wrapper, consumers, test helpers, mocks and the AuthorizedReceiver, KeepersVRFConsumer, VRFOwner and VRFSubscriptionBalanceMonitor contracts that depend on the v2 coordinator interface) and removes their compile script entries. Also removes the corresponding go:generate directives and wrapper dependency-version entries (identical to the change in the VRF v2 wrappers removal PR, so the two can merge in either order). Co-Authored-By: Claude Code <noreply@anthropic.com> * Remove stale IAuthorizedReceiver entry from compile script The contract was deleted in this branch but its compile entry was missed, causing forge to fail with 'No source files found' and the wrapper generation verification to panic. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update GETH_VERSION to 1.17.4 in CRE gobindings versions files Wrapper regeneration updates these files to match the go-ethereum version in contracts/cre/gobindings/go.mod (bumped to v1.17.4 earlier in this PR), so they must be committed for the wrapper validation to pass. Co-Authored-By: Claude Code <noreply@anthropic.com> * Bump go-ethereum to v1.17.4 in contracts/cre/gobindings The revert of #572 downgraded go-ethereum to v1.17.4 in the root and gethwrappers modules but missed this nested module, causing the wrapper generation to fail with an abigen version mismatch in CI. Same change as in #571. Co-Authored-By: Claude Code <noreply@anthropic.com> * Remove stale VRF v1 entries from native_solc_compile_all_vrf The VRF v1 removal (#571) deleted these Solidity sources, but the compile script still referenced them, causing forge build to fail with "No source files found in specified build paths" in CI. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes VRF v1 contracts, wrappers and the VRFV1 transmit checker.
Originally this PR removed both VRF v1 and v2; it has been split so each lands separately. VRF v2 removal now lives in a follow-up PR based on this one.
Also bumps go-ethereum to v1.17.4 in contracts/cre/gobindings (missed by the revert of #572, which caused the abigen version mismatch in CI).