Repository navigation
feat(web): review Crew proposals from the composer - #751
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
9928455 to
750a201
Compare
Panel review: #751Live (Astra, stack tip): collapsed and expanded states, View more, Add/Edit/Remove, persona defaults, Escape and focus, and approval all passed (collapsed, expanded, persona defaults). The tester also recorded the interaction video this PR is missing. Ask if you want it. Should fix: editing a persona's loaded instructions sends both copies. The member dialog loads the persona's instructions into the editable box ( Nits
Review panel for the #750–#762 stack, judged as the code that lands at |
BastiHu
left a comment
There was a problem hiding this comment.
Inline findings from the crew review of #750, #751, #754 and #755, checked against this PR's current diff. Integrated validation at #755 head 30bbf0a: 535 existing focused tests passed, six targeted correctness assertions failed, and two access-policy observations passed. Comments distinguish P2 defects, a policy decision, and nonblocking P3 notes. No source changes were made.
750a201 to
7cc5ca7
Compare
7cc5ca7 to
cee5047
Compare
|
Thanks. Here's where each one landed:
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…#742) The composer unmounts the roster gate while an approval or question is up, which threw away the card's saved edits. A small J5-owned store keyed by environment and proposal restores them, and approving or declining clears them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…at launch (#742) The member dialog loaded the persona's text into the editable box, so after any edit the whole copy was sent beside the persona's own. A new optional personaInstructions on the proposal seat, set only by the roster card, carries the edited text. Launch snapshots the persona with it, so the original is not also sent, and the box offers Reset to persona text. The agent's own instructions field and the agent tools are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ch chip (#742) An edited snapshot differs from the library's definition because the person chose it. The assignment records instructionsEdited at launch, and agentPersonaDrift reports unknown for it, so web and mobile show no chip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rting (#742) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3590367 to
0335681
Compare
BastiHu
left a comment
There was a problem hiding this comment.
Approved at 0335681. The remaining empty-persona-instructions issue is fixed: clearing the box now reports a validation error and disables Save, whitespace-only replacements are rejected, and Reset to persona text restores a valid member without silently discarding an edit.
Verified the source and ran crewProposalDraft.test.ts and CrewProposalCard.test.tsx on this exact head: 34 tests passed across 2 files, including clear/blocked/reset/save/approve and the existing nonempty replacement and draft-restoration regressions. CI is green. Range-diff confirms the previously reviewed #751 commits are unchanged by the rebase, with this fix added. The follow-up in #751 (comment) is addressed.
The old seat dialog is gone in this layer, so main's edits to it and its test are dropped; the roster gate, proposal card and preview hook keep main's compiler-friendly style. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ore reads Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…roposal UI The React Compiler memoizes these files, so the useMemo calls are plain values. The card saves its roster draft in the handler that changes the rows instead of an effect. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Summary
Crew proposals took too much space above chat and exposed member editing in the roster. I moved the proposal into a collapsible composer attachment alongside Playbooks, kept member rows compact, and added shared Add/Edit modals with saved-persona defaults. Closes #742.
This PR targets
j5/741-quieter-captain-timeline.Review fixes since the first version:
cb9eab8f71).personaInstructionsfield that only the roster card sets; agents'instructionsstill mean "additional". The dialog has a "Reset to persona text" button, and an edited seat doesn't show the "persona changed" chip. Clearing the box entirely isn't allowed: Save stays off with a message until the text is reset (e2cdd71bd2,a116922787,0335681d8b).cee5047b8a).a74015ae0f).Evidence
At
0335681d8b, on top of #750, after the stack was rebased onto j5/main. The commit-level checks for the review fixes are listed first, then the earlier evidence at99284552af:src/j5(510 tests) and serversrc/j5/a2a(787 tests) pass ate2cdd71bd2, and the chip commit's focused tests (drift and launch) pass with lint and typecheck clean.99284552af, 80 focused tests passed:vp test run apps/web/src/j5/crew/CrewProposalCard.test.tsx apps/web/src/j5/crew/crewProposalDraft.test.ts apps/web/src/j5/crew/crewSeatRuntime.test.ts apps/web/src/j5/crew/useCrewProposalPreview.test.tsx apps/web/src/j5/crew/crewPlaybookPlan.test.ts apps/web/src/j5/crew/crewProposals.logic.test.ts apps/web/src/j5/crew/crewNotices.logic.test.ts apps/web/src/j5/playbooks/PlaybookStages.test.tsxinstructionsrequest still replaying unchanged.vp run --filter @t3tools/web typecheck.git diff --checkpassed.UI changes
The proposal starts collapsed above the composer and remembers its disclosure state. The brief is limited to two lines with View more / View less. Compact member rows show provider logos, names, model/reasoning/access, short reasons, and Edit/Remove icons. Add member, Decline, and Approve Crew stay in the footer. The shared Add/Edit modal follows the approved layout, with separate Provider/Model controls and saved-persona name, instructions, and runtime defaults.
Before:
04b7a0df9ad77d27abe7dbb75360c34db8e0b866. After:99284552af8a120355005d6435dd0c18a0c3c6f9. Both use isolated TODO-filter proposals at 1280×800; the original base and current head proposals were generated in separate authorized turns, so their text is not byte-identical.The PNGs are uploaded on
j5/evidence, outside the source branch. I verified all seven uploaded files byte-for-byte through GitHub's API. The local corporate proxy returns 403 for raw image URLs, so inline rendering could not be confirmed here.Video pending: a fresh interaction recording could not be made. J5 browser snapshots repeatedly timed out; Chrome provided the screenshot fallback, but native recording failed with
cgWindowNotFound/timeoutReached. No superseded video is presented as current-head evidence. Manual capture steps: expand the proposal, toggle View more, edit/cancel a member, select a saved persona and cancel, add/remove a member, then collapse the proposal. Stop before approval.Live testing
PASS for the changed proposal/editor UI at
99284552af8a120355005d6435dd0c18a0c3c6f9; PARTIAL for the full Crew lifecycle. I re-tested the integrated final UI on the isolatedsetup-agent-live-test.tsserver through the authorized Chrome fallback. The proposal was generated by the previously authorized Haiku 5.5 turn at137f12057092d8e069cd043a11fa06695f81091b; no additional provider turns ran for this final pass.Verified the initially collapsed strip, expanded roster, two-line brief disclosure, Edit/Cancel/Save, saved-persona name/instructions/provider/model/reasoning/access defaults, retained edits across folding, and adding/removing a draft member with the live count returning from four to three. No Crew was approved and no members launched. Focused tests cover approval tokens, permission checks, stale preview handling, and keyboard restoration.
Not verified: approval/launch and the resulting Captain notice, playbook proposals, Inbox in a real browser, desktop shell, remote/relay/tunnel modes, and multi-device approval races. Those need a separate live pass; approval would require a new explicit model/launch grant. The interaction video remains outstanding. The roster-edit restore, the persona replacement and the approver line were not re-run live here; tests cover them.
Upstream impact
ChatView.tsxpasses the J5 gate through the existingthreadProgressControlslot alongside Playbooks. The integration is recorded inFORK.md, case 24; it reuses upstream's composer attachment primitives without changing their behavior.Source scope is web and desktop's shared UI, including Inbox proposal cards. The proposal seat gains one optional
personaInstructionsfield and the persona assignment one optionalinstructionsEditedmarker, both J5-owned and only set by the roster card; provider adapters are unchanged and mobile is outside this feature. Destination-environment permissions and server preview validation remain authoritative.Merge Danger
Door: two-way; reverting restores the previous presentation. No migrations. The two new fields are optional and only appear in approved seats, so a revert just ignores them.
Blast Radius: Crew proposals in web/desktop chat and Inbox, plus Captain approval-notice rendering from the earlier work in this PR.
The main risks are persona defaults/instruction handling, modal picker/focus behavior, and stale approval previews. Approval continues to require a matching full-roster token and server validation. The final proposal/editor UI was checked in Chrome; the earlier independent code/security reviews covered the superseded head, not this redesign.
After merge: nothing; no migration or activation step.
Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.md— not applicable; existing J5 integration onlyAGENTS.md) — scope and live gaps assessed abovedocs/j5/product/and user docs rewritten where this changes themImplemented with GPT-6.1-Sol in the Codex harness.