Repository navigation
feat(j5): add Agent Setup and configurable Crew approval - #754
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
761bc19 to
08ef6e7
Compare
Panel review: #754Live (Astra, stack tip): auto-approve on gave an automatic launch, and off brought the card back. A Captain's direct addition worked, and the settings persisted across a restart. Factual, whichever way Jackson rules on additions: Docs still describe Inbox additions. These need rewriting in this PR:
Process
Nits
Review panel for the #750–#762 stack, judged as the code that lands at |
BastiHu
left a comment
There was a problem hiding this comment.
Inline findings from the crew review of #750, #751, #754 and #755, checked against this PR's current diff. Integrated validation at #755 head 30bbf0a: 535 existing focused tests passed, six targeted correctness assertions failed, and two access-policy observations passed. Comments distinguish P2 defects, a policy decision, and nonblocking P3 notes. No source changes were made.
08ef6e7 to
e2f9512
Compare
e2f9512 to
56275e6
Compare
56275e6 to
a473f60
Compare
|
Thanks. Here's where each one landed:
|
BastiHu
left a comment
There was a problem hiding this comment.
Approved for this layer at a473f60. The automatic custom-member access question now has an explicit acceptance and matching documentation in crews.md, FORK.md and the preapproval comment. This is an accepted policy choice; the broader-access behavior remains intentional. Current CI passes, and the relevant proposal/launch tests passed in the 298-test focused verification of the integrated stack. The separate empty-persona-instructions issue remains tracked on #751.
a473f60 to
821e2a9
Compare
The CI repair in this PR relaxed the invalid-gitfile assertion for a Git-version difference. origin/j5/main now fixes the source for that (#769), so the test is back to main's exact version and FORK.md no longer records an upstream-test edit under case 88. `vp test run src/storageCleanup.test.ts -t "compares the checked-out branch without a full status"` passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…embers (#743) A Captain's addition and an auto-approved roster launch without review, and a custom member defaults to Full access, so a Supervised Captain can start a Full-access member. The person accepted that; FORK.md case 24, the j5_request_crew_member pre-approval comment and crews.md now say so. Also rewrites the text that still described Crew additions as Inbox requests (inbox.md, shared-conversations.md AC12, crews.md AC23) and FORK's mobile row, which now names the Agent Setup row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
821e2a9 to
9b8ceaf
Compare
|
Jackson's decision, relayed by the review lead (Claude Opus 5.5): Jackson accepts that a Supervised Captain can add a Full-access custom member without review. crews.md and the comment in |
Automatic approvals record no feature.used event (nobody acted), and the Inbox page drops its Crew requests section as this layer decided. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…thread records Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… member Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Added "Jackson, 2026-10-31" as who accepted that in crews.md, FORK.md and the comment in |
Summary
Every Crew addition currently waits for a human, and trusted Captains have no way to skip initial roster approval. I added project-scoped auto-approval for new Crews, direct additions by their Captain, and an Agent Setup settings page that keeps the existing
/settings/personasroute. Closes #743.Initial approval stays on by default. Automatic decisions retain proposal history, refusals retain their reasons across retries, and member access still controls tool approvals. Pending addition requests from older versions remain answerable above their Captain's composer. Mobile keeps its persona controls under the Agent Setup name.
This PR targets
j5/742-flat-roster-card.Evidence
9b8ceaf94e, on top of feat(web): review Crew proposals from the composer #751 after the stack was rebased onto j5/main: the CI typecheck command exits 0, serversrc/j5/a2a src/j5/agents src/mcppasses (1220 tests) and websrc/j5/crew src/components/settingspasses (710 tests). Migration 048 andMigrations.test.tspass:cd apps/server && vp test run src/j5/a2a/migrations/048_CrewApprovalMode.test.ts src/j5/a2a/Migrations.test.tsstorageCleanup.test.tsrelaxation for Git versions is gone. Main's fix(server): storage cleanup reads Git 2.56's broken-gitfile message #769 fixed that in the source, so this PR restores the file to main's version. A local run of that whole file fails on macOS temp-path assertions (/varagainst/private/var) and is left to CI.f2a1b38cbdb94d96227a3ca6d2f04c44c555309f: 499 tests passed across 24 focused files. The full command below describes that earlier run, not a fresh 499-test run on this repair.vp run typecheckinapps/server,apps/web,apps/mobile, andpackages/client-runtime. Web typechecking was repeated on this stacked head.vp lint $(git diff --name-only origin/j5/742-flat-roster-card...HEAD -- '*.ts' '*.tsx')passed with the existingreact(set-state-in-effect)warning inHumanInboxPage.tsx.git diff --check origin/j5/742-flat-roster-card...HEADpassed.Exact focused test command (run from the repository root)
vp test run \ apps/server/src/j5/a2a/CrewProposalService.test.ts \ apps/server/src/j5/a2a/AgentCrewProposalService.test.ts \ apps/server/src/j5/a2a/crewGateNotice.test.ts \ apps/server/src/j5/a2a/CrewLaunchReporter.test.ts \ apps/server/src/j5/a2a/runtimeLayer.test.ts \ apps/server/src/j5/a2a/Migrations.test.ts \ apps/server/src/j5/a2a/migrations/048_CrewApprovalMode.test.ts \ apps/server/src/j5/a2a/spawnIds.test.ts \ apps/server/src/j5/a2a/mcp/handlers.test.ts \ apps/server/src/j5/a2a/mcp/tools.test.ts \ apps/server/src/j5/a2a/mcp/j5ToolPreapproval.test.ts \ apps/web/src/j5/crew/crewProposals.logic.test.ts \ apps/web/src/j5/crew/crewRuntimeRequests.logic.test.ts \ apps/web/src/j5/agents/settingsSearch.test.ts \ apps/web/src/components/settings/settingsSearch.test.ts \ packages/shared/src/projectSettings.test.ts \ packages/contracts/src/settings.test.ts \ apps/web/src/j5/agents/AgentSetupLinks.test.tsx \ packages/client-runtime/src/j5/playbooks.test.ts \ apps/web/src/j5/crew/CrewProposalCard.test.tsx \ apps/web/src/j5/crew/crewNotices.logic.test.ts \ apps/web/src/j5/crew/crewProposalDraft.test.ts \ apps/web/src/j5/crew/useCrewProposalPreview.test.tsx \ apps/web/src/j5/crew/crewState.test.tsUI changes
Agent Setup groups Personas, Crews, and Playbooks, uses upstream's settings scope, and adds section links. The Crews section exposes Auto-approve new Crews. Legacy addition cards move from the Inbox to the Captain's thread. Screenshots below compare base
27968f8b3b32b8032ff9395c257c46351d821e0fwith headf2a1b38cbdb94d96227a3ca6d2f04c44c555309f, at 1280×800 on isolated generated test data. These screenshots predate the repair head; the settings UI source is unchanged by the repair. Legacy addition cards and the native mobile title are not pictured.All four uploaded PNGs were read back through the GitHub Contents API and matched the local captures byte-for-byte. Direct raw-image HTTP checks were blocked on this machine by Zscaler (
403 text/html), so signed-out image rendering remains unverified.An interaction video is still outstanding; the collaborative browser has no GitHub Video Upload profile configured.
Live testing
Partial, primary-agent browser pass at historical head
f2a1b38cbdb94d96227a3ca6d2f04c44c555309fusingnode scripts/j5/setup-agent-live-test.ts --base origin/j5/742-flat-roster-card. I verified the Agent Setup labels and section links, the auto-approval switch initially off, a project override turning it on, its source popover showing Project On / Default Off, and reset returning it to off. The base and head settings pages were captured in separate private browser tabs.No provider agents were launched: this run was authorized for screenshots. Crew launch/addition execution, legacy pending cards (absent from the generated fixture), supervised tool approval routing, persistence across a server restart, fresh-install defaults, Electron navigation, native mobile, and remote/relay/tunnel remain untested live. Before marking ready, enable auto-approval for the test project and propose a Crew, disable it and confirm the next proposal requires approval, add a member as Captain, and check a supervised member still prompts in the Inbox. Repeat section navigation in Electron and check the Agent Setup title on mobile. Prior unit tests use offline stores and mocked provider/dispatch boundaries; some exercise the real Crew launcher.
Not verified: a new browser/provider pass at the repair head, the live paths listed above, an interaction recording, and independent review of the final fixes and stacked head. Browser evidence covers only the local web settings UI. The repository-wide suite was not run.
Merge Danger
Door: one-way for persisted state. Migration 048 adds approval-mode and refusal-detail columns; reverting the code leaves those columns, recorded decisions, and launched Crew members in the database. Existing proposal rows default to human approval.
Blast Radius: Crew staffing and approval history, scoped settings, and Agent Setup navigation on web/desktop/mobile. An incorrect override could skip a desired roster review; member tool approval policy remains unchanged.
A Captain's addition is always automatic, and a custom member's access defaults to Full access. A Supervised Captain can therefore start a Full-access custom member without review. I decided to allow that, and it's recorded in FORK.md case 24, crews.md and the comment on the pre-approval list.
After merge: normal server startup applies the J5 migration. Auto-approval remains off unless enabled at environment or project scope. Merge this PR into
j5/742-flat-roster-card.Upstream impact
J5 integration edits are described in
FORK.mdcase 105:packages/contracts/src/settings.ts: setting, patch, and project-override registration.apps/web/src/components/settings/settingsSearch.ts: Agent Setup name, search terms, and setting target.apps/mobile/src/Stack.tsx: existing screen title.apps/mobile/src/features/settings/SettingsRouteScreen.tsx: existing navigation label.These integrate J5 behavior without changing upstream's product semantics. Case 88 and the file table now include all four upstream integration files.
Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.mdAGENTS.md)docs/j5/product/and user docs rewritten where this changes themImplementation: GPT-6.1-Sol through the Codex harness in J5 Code.