Repository navigation
feat(j5): start Crew members on their first assignment - #755
bryantderosier merged 16 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
c081af1 to
30bbf0a
Compare
Panel review: #755Live (Astra, stack tip): with real Haiku and Luna seats, no provider session existed before the first assignment (Not started). The first turns carried the introduction, and a later added member reached the next assignment as a roster delta. The tester checked native session files, the database and receipts. Should fix: a seat whose first turn fails still says "Not started". Reproduced live: the tester broke the test server's Codex path and sent a Luna seat its first assignment. The run failed, the Captain showed the red line, and the Crew summary said "1 failed". The seat's own row in Fleet and in the sidebar still said "Not started" (Fleet row, sidebar). Should fix: a seat loses its introduction on a context handoff. The brief, seat instructions, Before merge (the migration is one-way): Dead code that can bite. Nits
Review panel for the #750–#762 stack, judged as the code that lands at |
BastiHu
left a comment
There was a problem hiding this comment.
Inline findings from the crew review of #750, #751, #754 and #755, checked against this PR's current diff. Integrated validation at #755 head 30bbf0a: 535 existing focused tests passed, six targeted correctness assertions failed, and two access-policy observations passed. Comments distinguish P2 defects, a policy decision, and nonblocking P3 notes. No source changes were made.
30bbf0a to
c680837
Compare
c680837 to
6c8149e
Compare
Record a seat's context as delivered only when the provider took the send, so a start stopped or superseded before startTurn leaves it owed. A steered message to a busy seat now carries the current context too. The full introduction is sent again when the provider conversation it reached is replaced (model or provider switch, lost native session). Threads that are not Crew seats skip the Crew path entirely again. Drops the four unused pending_* columns from migration 49. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…arted (#745) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The unwrap only served an envelope shape that was never merged, and it would cut authored text that begins with the marker. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ey now behave (#745) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…745) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
601321a to
9f04c46
Compare
|
Review panel: Claude Opus 5.5 (lead) and GPT-6.1 Sol. We reviewed the whole stack at Should-fix: every turn and steer on a seat bumps the A 20-message review loop makes every client re-read Crew proposals, runtime requests and sidebar chips 20 times. Only the first delivery, or a roster or conversation change, changes anything. Suggestion: skip the UPDATE and notify when the roster JSON and conversation are unchanged. Nits
|
|
Jackson's decision, relayed by the review lead (Claude Opus 5.5): a member's introduction must be visible in its own thread. Since this PR, approval stores the brief, roster, collaboration rules and seat instructions in Please make what the member was told visible in its thread. |
…nt layer Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e label Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the roster keeps launch names A follow-up or steer to a seat whose roster and conversation are unchanged no longer updates the seat context or bumps the crew and fleet feeds. The delivered roster names each seat as it was launched instead of by persona id. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Went through both comments:
|
A record-only platform message joins a thread's history without starting a run. When a seat's prompt carrying the introduction or a roster change is accepted, the seat's thread records that text once. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The introduction and each roster change appear as a collapsed card that opens to the text the model read, on web and mobile. Records the new internal command in FORK.md (case 106) and the register (D43). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Did the introduction one too. Once the provider takes a prompt that carried the intro or a roster change, the member's thread records exactly what the model read as a collapsed card ( |
…t imports it (#745) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Summary
Crew approval currently starts every member before there is an assignment. I create waiting seats, save their approved introductions, and deliver each introduction with the first assignment the provider accepts. Later assignments carry net roster changes. Closes #745.
Fleet and spawned-member views show Not started, and a seat whose first start failed shows its failed or interrupted label instead.
Review fixes since the first version:
25ef2b7bae).ProviderTurnControlServicerecorded in FORK.md (25ef2b7bae).25ef2b7bae).25ef2b7bae).25ef2b7bae,32f5dde873).bee2e47a34).pending_*columns (25ef2b7bae).I left two nits: the roster still shows a persona's id rather than its display name, and
notStartedstays optional because a member with no seat-context row reads as NULL. Worktree preparation remains separate from provider startup. This PR targetsj5/743-agent-setup-crew-approvaland preserves the approved #751 proposal/editor UI through its parent update.Evidence
At
9f04c4637f, on top of #754, after the stack was rebased onto j5/main. The CI typecheck command exits 0 here:src/j5/a2a src/j5/agents src/mcpplus the twoProviderTurn*tests pass (1275 tests), websrc/j5passes (519) and contracts passes (718).cd apps/server && vp test run src/j5/a2a/migrations/049_CrewSeatActivation.test.ts src/j5/a2a/Migrations.test.tsEarlier evidence at
c081af1245:vp test run apps/server/src/j5/a2a/CrewDeliveryContext.test.ts apps/server/src/j5/a2a/CrewDeliveryContext.integration.test.ts apps/server/src/orchestration-v2/ProviderTurnStartService.test.ts apps/server/src/j5/a2a/CrewLaunchService.test.ts apps/server/src/j5/a2a/CrewLaunchReporter.test.ts apps/server/src/j5/a2a/AgentCrewInstanceService.test.ts apps/server/src/j5/a2a/CrewProposalService.test.ts apps/server/src/j5/a2a/migrations/048_CrewSeatActivation.test.ts apps/web/src/j5/a2a/ThreadA2ARenderer.test.tsx apps/web/src/j5/crew/crewState.test.tsvp exec tsc-rs --noEmit -p apps/server/tsconfig.jsonandvp exec tsc-rs --noEmit -p apps/web/tsconfig.json.git diff --checkpassed. Lint retains the existingreact(exhaustive-effect-dependencies)warning inThreadA2ARenderer.tsx.Not verified: Real provider turns, end-to-end approval/first-assignment behavior, desktop, mobile, remote/relay, and tunnel testing remain unrun. The tests use real orchestration/SQL paths with mocked provider boundaries. No new paid-model turns, browser captures, interaction video, or repo-wide checks ran for this repair. Earlier independent reviews covered the prior head; the repair has not had a new independent review.
Merge Danger
Door: One-way for persisted state: migration 49 creates and backfills
j5_crew_seat_context; reverting code leaves that table and its records behind. The repair adds no migration.Blast Radius: Crew seat creation and assignment delivery, worktree startup, shared-conversation context, Fleet/member status, and A2A message presentation.
The four previously recorded P2 findings are addressed:
stored_prefix, so connected author reads cannot retain an obsolete Crew prefix.After merge: Migration 49 runs through the normal J5 migration path.
UI changes
Waiting seats display Not started in Fleet and spawned-member views. The matching synthetic fixture below shows the change from Idle to Not started, including the Crew summary count. Both captures are 1280×800 from isolated local web clients.
f2a1b38cbd)39343ebf9b)The images are uploaded to
j5/evidence; GitHub API readback matches the local PNGs byte for byte. Direct raw-image fetch verification was blocked by the local corporate proxy (Zscaler HTTP 403). No video was recorded in this screenshot-only pass.Live testing
Partial web verification at head
39343ebf9bb848bcc6ab7f0f4ce32040504f16eb, compared with basef2a1b38cbdb94d96227a3ca6d2f04c44c555309f, usingnode scripts/j5/setup-agent-live-test.ts --base origin/j5/743-agent-setup-crew-approval. I opened both isolated clients, expanded the Fleet Crew and sidebar member group, and captured the waiting labels. These are synthetic SQLite presentation fixtures, written while servers were stopped; they do not prove approval, delivery, or provider startup. No provider calls were made. Those screenshots cover the historical head. This repair changes context delivery and queue preview parsing; it has focused regression coverage but no fresh live provider/browser pass.The base install initially missed the repository’s existing
@pierre/diffspatch; applying that tracked patch to its installed dependency restored the client. No source changes were needed. Both test servers were stopped after capture.Hand verification should approve a shared-workspace Crew and a worktree Crew, confirm no member provider starts at approval, send a first assignment, verify the introduction and approved workspace, then change the roster and confirm the next assignment carries the net change. Repeat through human chat, agent messaging, and playbook delivery; cover queued edit/cancel/reorder and archive/reopen after the review fixes.
Upstream impact
apps/server/src/orchestration-v2/runtimeLayer.tswires the J5 dispatch guard and Crew delivery service into the shared runtime.ProviderTurnStartService.tsdelegates the selected assignment to the J5 service around provider delivery, including its budgeting path.ProviderTurnStartService.test.tscovers that integration without a history handoff. These J5-only hooks and all three file-table rows are recorded inFORK.mdcase 106. Ordinary non-Crew messages retain their text and upstream delivery semantics. Production provider adapters are unchanged.apps/server/src/orchestration-v2/Orchestrator.tsand the orchestration contracts gain one server-only command,platform-message.record, which records a platform message in a thread without starting a run. A member's introduction and roster changes use it so they're visible in the member's thread. It's in FORK.md case 106 and register entry D43 (Jackson's decision, approved by Bryant).Checklist
FORK.md(case text and file-table row) in this PRdocs/j5/product/upstream.md— J5 Crew behavior; no upstream product divergence introducedAGENTS.md) — static/shared-path coverage only; live coverage outstandingdocs/j5/product/and user docs rewritten where this changes themImplementation and repair: GPT-6.1 Sol through the Codex harness. Earlier-head independent reviews: GPT-6 Astra and Claude Opus 5.5.
What a member was told
Added by the review panel after merge, from a live test of the merged code on an isolated test server. The card is new, so there's no before. The red provider error in the first image is tracked separately in #913.