Repository navigation
feat(web): a Captain's timeline shows only what needs the person - #750
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
04b7a0d to
f7a7c25
Compare
Panel review: #750Live: the quiet timeline, compact member rows and the red failure line all worked at the stack tip (red line, member rows). Should fix: an approved roster no longer says who approved it. Review panel for the #750–#762 stack, judged as the code that lands at |
BastiHu
left a comment
There was a problem hiding this comment.
Inline findings from the crew review of #750, #751, #754 and #755, checked against this PR's current diff. Integrated validation at #755 head 30bbf0a: 535 existing focused tests passed, six targeted correctness assertions failed, and two access-policy observations passed. Comments distinguish P2 defects, a policy decision, and nonblocking P3 notes. No source changes were made.
f7a7c25 to
3c1aa7d
Compare
|
Thanks. Going through the panel comment:
CI is green on |
A Captain's conversation was mostly the platform reporting on itself: a roster card after every launch, a card per seat finish, and member messages as full cards. Launch and finish notices now draw one line per seat that needs the person (couldn't start, never created, start unconfirmed, failed, handoff missing or unreadable) and nothing otherwise, a live Crew member's message is a compact row led by its provider, and seat rows on the Fleet page and the Captain's expander say how the last run ended instead of Idle. Render-time only: the Captain receives the same notices and turns, and no upstream file changes. Closes #741. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes on the quieter Captain timeline (#741): - Hidden notices are dropped after upstream derives the timeline rows, not from the entries before it, so a Captain turn started by a hidden finish or launch notice keeps its turn boundary (folding, terminal message, rollback). One line in MessagesTimeline.tsx, recorded as FORK.md case 87; the filter in the shared-conversation hook is gone. - Notice lines are keyed by seat and position, since a folded notice can carry one seat twice. - Failed, Interrupted and Completed label only Crew seats; solo agents keep upstream's Idle. - A peer card selects one boolean for "is a live Crew seat", and only a compact row reads the server configs, so non-seat cards no longer re-render on every spawned-children read. - A line names its Crew when one notice spans several Crews. - Comments record why the parser keeps fields the timeline no longer draws, why a failed seat always carries a detail, and why a member's message falls back to the card before the seat read lands. - The user guide states the behaviour without describing the UI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6858e28 to
431e17c
Compare
|
From Jackson, relayed by the review lead (Claude Opus 5.5): notifying the Captain every time a member's turn ends is noise, and he'd like that explored. This PR hides clean finish notices from the person's view, but the Captain still takes a turn on each one. Jackson says it's up to you whether you change it in this stack or later. |
Peers' messages now render in upstream's user row, so the compact Crew member row is dropped; the hidden Crew notices and seat run labels stay. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Merged On Jackson's note about the Captain taking a turn on every finish: I'm leaving that for a later change, it's its own piece of work. |
Problem
Most of what landed in a Captain's conversation was the platform talking about itself: a "Crew launched" roster card after every approval, a "Seat finished" card every time a seat's run ended, and member messages as full cards. The stuff I'd actually act on got buried. Closes #741.
What changed
It's all at render time. The Captain still gets the exact same notice text and turns, and nothing on the server or in contracts moves.
crew/crewNotices.logic.ts: newcrewNoticeLinesturns a launch report or finish notice into one line per seat that needs me:isHiddenCrewNoticeis true when there's nothing to draw. The helpers only the old cards used are gone.MessagesTimeline.tsx(upstream, one line, FORK.md case 104):withoutHiddenCrewNoticesdrops a clean launch or finish notice's row after upstream derives the rows. It has to be after, because upstream treats every user message as a turn boundary for folding, the terminal message and rollback, and dropping the notice earlier merges the Captain turn it started into the one before. It hands back the same array when nothing's hidden, cached per input, sinceuseStableRowschecks identity.crew/CrewNoticeRenderer.tsx: approved gates and finish notices render as those lines, each opening its seat. A line names its Crew only when one folded notice spans several Crews. Declined gates keep today's card.crew/crewState.ts→seatRunLabel: a Crew seat's row on the Fleet page and in the Captain's expander says Failed, Interrupted or Completed instead of Idle once upstream's pill has nothing to say. Solo agents keep upstream's Idle.Docs:
crews.md(definition paragraph, AC22, History) and the user guide indocs/j5/user/personas.md.Things I left on purpose:
UI changes
The Fleet and expander "before" shots are the same image, since one screenshot showed both. The review panel saw the red failure line live at the stack tip (screenshot); there's no shot of an amber line.
Upstream impact
apps/web/src/components/chat/MessagesTimeline.tsx: one J5 import and one changed line inConversationTimeline(rows = useStableRows(withoutHiddenCrewNotices(rawRows), ...)). It's recorded as FORK.md case 104, and the file-table row now lists 104. It doesn't change what upstream's product does; it only leaves J5's own notices out of the rows.Live testing
I tested on a disposable test server with real Claude and Codex seats. I took the "before" shots from a
j5/mainbase build and the "after" shots from this branch's diff.getAnimations()returns 0.crewNotices.logic.test.tsandcrewState.test.ts.I live-tested the feature commit (
814b5b2e4a) before the code-review fixes. Since then,3c1aa7d331moved the hide filter from the entries to the derived rows, re-keyed lines, limited the seat labels to Crew seats, cut re-renders and trimmed a doc line. None of that was re-run live: the rendered output for the cases above is the same, and the boundary fix is covered by the newwithoutHiddenCrewNoticestest plus upstream's ownMessagesTimelinetests, which pass.I also ran plan reviews, three code-review rounds and two security reviews on it. There were no security findings, and the code-review fixes are in
3c1aa7d331.Checklist
FORK.md(case text and file-table row) in this PR (case 104)docs/j5/product/upstream.md(n/a)AGENTS.md)docs/j5/product/and user docs rewritten where this changes themClaude Opus 5.5 via J5 Code (Claude Code harness)
🤖 Generated with Claude Code