Repository navigation
[vite-plugin] Reuse refreshed OAuth credentials in v1 remote bindings - #16930
petebacondarwin wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: fda3744 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@petebacondarwin (verified author) and @dario-piotrowicz (latest verified human ant-core approval before merge, 2026-11-13T20:29:17Z), please check this Vite plugin v1 backport of #16874 and approve it if it looks good. Retained private remote-bindings authenticates through its own pinned workers-auth package, so this updates that direct dependency to the intended 0.18.3 fix without copying upstream source or tests. The earlier Artifacts-events backport already supplies the coupled Wrangler 4.163.0 pin. This remains draft pending npm publication, lockfile regeneration and final validation, at the top of native GitHub stack #16900. |
99735a5 to
773d22b
Compare
commit: |
commit: |
There was a problem hiding this comment.
Superseded by the review of
fda37443.
This review, of 773d22bd
✅ Approved — A minimal, consistent dependency pin bump with a matching lockfile update and changeset; no issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🚀 Release: ✅ LGTM
The patch changeset for @cloudflare/vite-plugin matches the user-facing change: remote bindings reuse credentials that another process has refreshed. The exact pin of @cloudflare/workers-auth@0.18.3 and its lockfile resolution are consistent. The description says no credentialed end-to-end run was done.
🔒 Security: ✅ LGTM
No issues found. The dependency stays an exact-version pin, and the lockfile integrity hash is updated for 0.18.3.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: 773d22bd
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
773d22b to
fda3744
Compare
|
Codeowners approval required for this PR:
|
There was a problem hiding this comment.
✅ Approved — A minimal, consistent dependency pin bump with a matching lockfile update and changeset; no issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🚀 Release: ✅ LGTM
The patch changeset for @cloudflare/vite-plugin matches the user-facing change: remote bindings reuse credentials that another process has refreshed. The exact pin of @cloudflare/workers-auth@0.18.3 and its lockfile resolution are consistent. The description says no credentialed end-to-end run was done.
🔒 Security: ✅ LGTM
No issues found. The dependency stays an exact-version pin, and the lockfile integrity hash is updated for 0.18.3.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
No issues found.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: fda37443 — same changes as 773d22bd, so this is that commit's review (no new review was run; line numbers are as of 773d22bd)
Backports #16874 to Vite plugin v1. Retained private remote-bindings calls
createWranglerAuthfrom its direct workers-auth dependency to authenticate remote bindings. Pin workers-auth 0.18.3 so its long-lived OAuth flow reuses a valid token refreshed by another process instead of exchanging and overwriting credentials again. This direct pin is independently necessary: upgrading the plugin's Wrangler dependency alone does not update retained remote-bindings' authentication implementation.Version Packages #16915 is merged and workers-auth 0.18.3 is published. The pnpm-generated lockfile now resolves that exact version. #16929 supplies the coupled published Miniflare 5.20261116.0-beta, Wrangler 4.163.0, workers-utils 0.54.1 and deploy-helpers 0.27.1. This PR changes only remote-bindings' direct authentication pin, its lockfile resolution and the existing plugin patch changeset. Private workspace:* references are preserved; no public dependency implementation or upstream tests are copied.
Native GitHub stack #16900: #16818 → #16859 → #16860 → #16861 → #16899 → #16898 → #16929 → this PR. The stack preserves the updated #16899 remote-preview fix. Merge in order through the GitHub stack.
Validation with Node 22.22.1 / pnpm 10.33.0:
pnpm install,pnpm build,pnpm check(58 tasks), andpnpm test:ci(eight tasks) pass, including 269 plugin tests and 41 retained remote-binding tests. No credentialed E2E or OS/Vite matrix run.Note
This is a contribution from an AI agent: Codex.