Skip to content

[vite-plugin] Start v1 Workflows from local Artifacts events - #16929

Open
petebacondarwin wants to merge 2 commits into
codex/vite-v1-backport-16735from
codex/vite-v1-backport-16246
Open

petebacondarwin wants to merge 2 commits into
codex/vite-v1-backport-16735from
codex/vite-v1-backport-16246

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Backports #16246 to Vite plugin v1. triggers.events in Wrangler configuration now reaches the Miniflare V4 adapter so a local Artifacts mutation starts its owning Workflow. The plugin API integration test launches Vite with Wrangler JSON, creates a local repository, and observes the event in a Workflow through KV.

Version Packages #16915 is merged and published. Consume the actual Miniflare 5.20261116.0-beta release (superseding the predicted, unpublished 5.20261113.1-beta), Wrangler 4.163.0, workers-utils 0.54.1 and deploy-helpers 0.27.1. Plugin, retained remote-bindings, and the direct runtime fixture use the same Miniflare pin; Workers types align to 5.20261116.1. The pnpm-generated lockfile includes published registry metadata. The existing plugin minor changeset describes the user-facing feature and runtime upgrade.

This also supplies #16946's workerd/default compatibility-date upgrade and the compatible V4 adapter portion of #16907. V1 keeps Wrangler configuration and private workspace:* dependencies. No native-config API, public dependency source, dependency tests or removed fixtures are restored. #16898 supplies the earlier November 13 runtime; #16930 separately updates retained remote-bindings' direct OAuth dependency.

Native GitHub stack #16900: #16818 → #16859 → #16860 → #16861 → #16899 → #16898 → this PR. Descendants preserve the updated remote-preview fix on #16899. Merge in order through the GitHub stack.

Validation with Node 22.22.1 / pnpm 10.33.0: pnpm install, pnpm build, and pnpm check pass (58 check tasks); all 269 plugin tests pass, including the Artifacts event integration test. pnpm test:ci also passes all eight tasks, including retained remote-binding tests. No credentialed E2E or OS/Vite matrix run.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this consumes the original beta feature through v1 Wrangler configuration; the changeset explains configuration and local limitations.

Note

This is a contribution from an AI agent: Codex.

@changeset-bot

changeset-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9406dda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@leostera, as the verified author of #16246, please check this Vite plugin v1 backport and approve it if it looks good. I could not verify a human ant-core approval in the original review history, so I have not guessed another recipient.

V1 retains Wrangler JSON triggers.events and consumes the implementation through the Miniflare V4 adapter and Wrangler API. The test exercises Vite itself rather than copying dependency tests. #16898 already supplies the earlier Artifacts/default and Browser Run updates. This remains draft until Miniflare 5.20261113.1-beta, Wrangler 4.163.0 and coupled helpers publish, the lockfile is regenerated, and final validation passes. It is appended to native GitHub stack #16900.

@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16246 branch from d13365c to 9406dda Compare November 16, 2026 14:06
@petebacondarwin
petebacondarwin marked this pull request as ready for review November 16, 2026 14:06
@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team November 16, 2026 14:06
@workers-devprod

workers-devprod commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@workers-devprod (recorded release PR author, bot-operated account) @edmundhung (human ant-core approver): please check the v1 dependency adaptation of #16915 in this backport and approve it if it looks good.

This existing Artifacts backport consumes the actual published Miniflare 5.20261116.0-beta release, superseding the predicted unpublished .1-beta from November 13, together with Wrangler 4.163.0 and the required shared dependencies. The lockfile is regenerated from npm, and build, all 58 checks and all eight test tasks pass, including 269 plugin tests. Earlier release coverage stays in #16898; #16930 separately supplies the direct retained OAuth pin. No separate release-mapping PR is needed.

@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16929

commit: 9406dda

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — I found no issues: the dependency pins are consistent and exact, the new integration test covers the feature, and the changeset is appropriate.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Overall Risk: Medium

The Miniflare beta and Wrangler upgrades change the local Worker simulation environment. The versions match across packages and the change can be reverted. The changeset's minor bump and feature description fit the project's release conventions.


🔒 Security: ✅ LGTM

No security issues found.


📖 AGENTS.md: ✅ LGTM

No AGENTS.md concerns.


📋 Code Quality: ✅ LGTM

No code quality issues found.


⚡ Performance: ✅ LGTM

No performance issues found.


📝 Documentation: ✅ LGTM

The changeset describes the feature and its local limitations.


Reviewed commit: 9406ddac

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants