Repository navigation
[vite-plugin] Update v1 to the November 12 runtime - #16859
petebacondarwin wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: d88380d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
|
|
@workers-devprod (recorded bot author of #16814 and #16836) and @edmundhung (verified human ant-core member who approved both originals before merge): please check this v1 backport and approve it if it looks good. One upgrade to the published Miniflare 5.20261110.2-beta covers both release PRs. Wrangler 4.161.0 is coupled here to align its exposed Miniflare types; all retained consumers and the lockfile are updated together. V1 retains the v4 compatibility adapter and its private workspace packages. The existing Container diagnostic backport #16818 remains below this PR; its containers-shared 0.25.0 API stays compatible. Build, all 58 checks, package tests and affected asset playgrounds pass. |
commit: |
There was a problem hiding this comment.
Superseded by the review of
d88380d4.
This review, of 379316d0
✅ Approved — The version pins and lockfile entries are consistent, the plugin changeset is present, and no issues were found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
Versions are consistent across all manifests and the lockfile. The Wrangler 4.161.0 entry resolves to Miniflare 5.20261110.2-beta. The remaining 0-beta lockfile entry comes from @cloudflare/deploy-helpers and is expected. The changeset is a plugin patch, which is correct.
📝 Documentation: ✅ LGTM
The changeset accurately describes the runtime update.
Reviewed commit: 379316d0
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
…to codex/vite-v1-refresh-16859
There was a problem hiding this comment.
✅ Approved — The version pins and lockfile entries are consistent, the plugin changeset is present, and no issues were found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
Versions are consistent across all manifests and the lockfile. The Wrangler 4.161.0 entry resolves to Miniflare 5.20261110.2-beta. The remaining 0-beta lockfile entry comes from @cloudflare/deploy-helpers and is expected. The changeset is a plugin patch, which is correct.
📝 Documentation: ✅ LGTM
The changeset accurately describes the runtime update.
Reviewed commit: d88380d4 — same changes as 379316d0, so this is that commit's review (no new review was run; line numbers are as of 379316d0)
Consume the compatible Miniflare releases from #16814 and #16836 in Vite plugin v1. Pin 5.20261110.2-beta in the plugin, private remote-bindings package and account-ID fixture, with a regenerated npm-backed lockfile and a plugin patch changeset. This supplies the newer runtime's relative asset redirect normalization and preserves v4 configuration through the compatibility adapter. The .2 release supersedes .1, so #16836 needs no separate backport. Wrangler 4.161.0 is a required coupled upgrade: the old Wrangler exposed nominal Miniflare types from .0-beta, which fail plugin type checking against .2-beta. Update its plugin dependency/peer and retained fixture consumers in this PR. containers-shared stays at 0.25.0, preserving the approved parent diagnostic API.
Stacked above #16818 in native GitHub stack #16900. The parent is synchronized with current vite-plugin-v1 so the remaining dependency diff excludes the already-released framework build fixes. Merge in stack order.
Validation on the combined stack: Node 22.22.1 / pnpm 10.33.0; pnpm build and pnpm test:ci pass (8 tasks, including 267 plugin tests, 38 remote-bindings tests and retained worker suites).
Note
This is a contribution from an AI agent: Codex.
Further validation: pnpm check passes all 58 tasks; affected Vite 8 asset playgrounds pass in development (14 passed, 7 skipped) and build/preview (20 passed, 1 skipped). Full Vite/OS/package-manager E2E matrix and credentialed remote tests were not run.
Retained integration validation also passes: pnpm test:fixtures (6 tasks), including all 30 dev-registry tests, 5 test-harness Vitest tests and both test-harness browser tests.