Skip to content

[vite-plugin] Update v1 to the November 12 runtime - #16859

Open
petebacondarwin wants to merge 2 commits into
codex/vite-v1-backport-16682from
codex/vite-v1-runtime-20261112
Open

petebacondarwin wants to merge 2 commits into
codex/vite-v1-backport-16682from
codex/vite-v1-runtime-20261112

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Consume the compatible Miniflare releases from #16814 and #16836 in Vite plugin v1. Pin 5.20261110.2-beta in the plugin, private remote-bindings package and account-ID fixture, with a regenerated npm-backed lockfile and a plugin patch changeset. This supplies the newer runtime's relative asset redirect normalization and preserves v4 configuration through the compatibility adapter. The .2 release supersedes .1, so #16836 needs no separate backport. Wrangler 4.161.0 is a required coupled upgrade: the old Wrangler exposed nominal Miniflare types from .0-beta, which fail plugin type checking against .2-beta. Update its plugin dependency/peer and retained fixture consumers in this PR. containers-shared stays at 0.25.0, preserving the approved parent diagnostic API.

Stacked above #16818 in native GitHub stack #16900. The parent is synchronized with current vite-plugin-v1 so the remaining dependency diff excludes the already-released framework build fixes. Merge in stack order.

Validation on the combined stack: Node 22.22.1 / pnpm 10.33.0; pnpm build and pnpm test:ci pass (8 tasks, including 267 plugin tests, 38 remote-bindings tests and retained worker suites).


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: existing plugin, private worker and integration suites cover this dependency upgrade; no dependency tests are copied.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fixes existing v1 behavior without adding configuration.

Note

This is a contribution from an AI agent: Codex.

Further validation: pnpm check passes all 58 tasks; affected Vite 8 asset playgrounds pass in development (14 passed, 7 skipped) and build/preview (20 passed, 1 skipped). Full Vite/OS/package-manager E2E matrix and credentialed remote tests were not run.

Retained integration validation also passes: pnpm test:fixtures (6 tasks), including all 30 dev-registry tests, 5 test-harness Vitest tests and both test-harness browser tests.

@petebacondarwin petebacondarwin added the ci:no-tests Skip pull request checks for tests label Nov 12, 2026
@changeset-bot

changeset-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d88380d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team November 12, 2026 14:04
@workers-devprod

workers-devprod commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@workers-devprod (recorded bot author of #16814 and #16836) and @edmundhung (verified human ant-core member who approved both originals before merge): please check this v1 backport and approve it if it looks good.

One upgrade to the published Miniflare 5.20261110.2-beta covers both release PRs. Wrangler 4.161.0 is coupled here to align its exposed Miniflare types; all retained consumers and the lockfile are updated together. V1 retains the v4 compatibility adapter and its private workspace packages. The existing Container diagnostic backport #16818 remains below this PR; its containers-shared 0.25.0 API stays compatible. Build, all 58 checks, package tests and affected asset playgrounds pass.

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16859

commit: d88380d

devin-ai-integration[bot]

This comment was marked as resolved.

@clanky-the-clanker clanky-the-clanker Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by the review of d88380d4.

This review, of 379316d0

✅ Approved — The version pins and lockfile entries are consistent, the plugin changeset is present, and no issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

Versions are consistent across all manifests and the lockfile. The Wrangler 4.161.0 entry resolves to Miniflare 5.20261110.2-beta. The remaining 0-beta lockfile entry comes from @cloudflare/deploy-helpers and is expected. The changeset is a plugin patch, which is correct.


📝 Documentation: ✅ LGTM

The changeset accurately describes the runtime update.


Reviewed commit: 379316d0

Comment thread .changeset/v1-nov12-runtime.md Resolved

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@clanky-the-clanker clanky-the-clanker Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved — The version pins and lockfile entries are consistent, the plugin changeset is present, and no issues were found.

The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

Versions are consistent across all manifests and the lockfile. The Wrangler 4.161.0 entry resolves to Miniflare 5.20261110.2-beta. The remaining 0-beta lockfile entry comes from @cloudflare/deploy-helpers and is expected. The changeset is a plugin patch, which is correct.


📝 Documentation: ✅ LGTM

The changeset accurately describes the runtime update.


Reviewed commit: d88380d4 — same changes as 379316d0, so this is that commit's review (no new review was run; line numbers are as of 379316d0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-tests Skip pull request checks for tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants