Repository navigation
Conversation
…mmands/session/ (#3172)
…oject_path/save/owner (#3172)
Move the production code of phone/mailbox.rs into 22 private submodules under phone/mailbox/, in dependency order so sibling modules form a DAG. mailbox.rs now only declares the children and re-exports the items that were already pub/pub(crate). The MailboxPoller impl is split into several impl blocks. Items, fields and methods used across the new siblings become pub(crate). Source-scan tests read the new files. Cycle baseline change: SCC 554acc49e7a211d1 (89 members) shrinks. phone::mailbox and phone::terminal_snapshot leave it; the rest becomes eb99a5c4b6de1586 (85) and fa5266e34a30725c (cli::create_agent, cli::create_agent_matrix). No module joined any cycle.
…mmands/session/ (#3172)
…ance/file/help/blocking_menu (#3172)
This was referenced Oct 22, 2026
|
Owner
Author
|
Superseded by #3178, which contains all of these commits plus the fixes for this PR's failing CI (Linux build, cognitive-complexity baseline, test-debt allowlist). Branch kept: batch 2 builds on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3172
Batch 1 of the Rust sanitizing campaign: behavior-preserving fixes done in parallel by fixer rooms 30, 31, 32 and 33 on one shared branch. Targets are only partly done; the campaign continues in the next batch, which branches from this head.
Measures (
src-tauri/src, base72aa89f-> headdde98bc)mod.rsmod x { }#[test]outsidetests.rs/tests/(C6)Largest targets:
config/settings.rs44554 -> 994,phone/mailbox.rs41542 -> 145,commands/session.rs24596 -> 9275,commands/config.rs16066 -> 358. Signal 02 count rose because giant files split into children that are still > 1000 lines (e.g.mailbox/tests.rs24408); next batch keeps splitting.Other changes
main(ci: add sanitizing baseline and text gates (refs #3167) #3170, ci: add layout and edge sanitizing gates (#3168) #3173 sanitizing gates), no conflicts.sanitizing_file_layout.mjs:use super::*;allowed in files undertests/(rule C6). Tests added.session/selection.rsandconfig/local_config_io.rsskip test-only files; production rules unchanged.Known gate failures (vs
main), to fix in the next batchfile_size(02): 14 files;line_length(01): 1 (mailbox/internal_delivery.rs, a test-pinned literal).file_layout(05): 23 (use super::super::*;inconfig/settings/tests/*.rs;*_tests.rsincommands/session/).tauri_edge(06): 24,global_state(08): 11,process_env(09): 1 — code moved to new files counted as new debt.Rooms
room-30 (
config/settings.rs), room-31 (phone/mailbox.rs), room-32 (commands/session.rs), room-33 (commands/config.rs).