Repository navigation
quest: plan load flakes, GOAWAY follow-ups, and the moq-quic transport direction - #6083
Conversation
…t direction Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d2eaad234
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…the fold's break Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7113184740
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…reset Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a34ae1a026
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba9f6c9ba6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
It is a moq-tokio API break, not QUIC stack work, and the new rank stays clear of the m1 lines moq-dev#6083 edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ssor in-tree Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…way-forks # Conflicts: # quest/m1/quic/group-reset.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a1319a44a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge summaryHead Codex findings fixed since the first review:
Merging main brought in #6041, which deleted Codex reviewed (Written by Claude Opus 5.5) |
Align with #6083: the m0 qmux credit quests stay deleted (qmux moves in-tree under m1/quic-qmux), so their README lines, the backport ranking note, and the audit's unverified qmux 0.6.4 follow-up go too. The m1 ranking keeps the audit's order and adds main's new quests; net-announced-follow stays at its m0 path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Plans the follow-ups from the 2026-10-20 merge batch, and applies the maintainer's decision that moq's own QUIC stack,
moq-quic, powers qmux and WebTransport. moq takes no new work in, or dependency on, moq-dev/web-transport, noq or quinn. web-transport stays published, and web-transport-proto may stay.Load flakes (
quest/m1/test-flakes-2/, 3 new children)draft16-cancel-race, ranked first: it fails on a mocked clock, so it may hide an ordering bug.relay-bench-holder: the test hangs on a fifo when its holder hits EADDRINUSE.tokio-failed-listen: the test releases its port before using it. Like moq-dev/moq#6032 it reserves the port, but the server must take the reservation over so the partial-bind path stays covered.GOAWAY follow-ups, from moq-dev/moq#5998
goaway-coverage.md. fix(net): handle GOAWAY throughout IETF request lifetimes #5998 completed it but left the file behind.namespace-advert-error: in Rust, one failed PUBLISH_NAMESPACE stream closes the whole session. AProtocolViolationfrom it also stops moq-tokio from reconnecting.tokio-redirect-loop: moq-tokio has the same A/B redirect-loop shape that moq-dev/moq#5959 fixes in JS.js-request-owner: every JS request stream gets one owning handle with anendedpromise, and one closer.Resumed forks:
resume-closed.mdgains a fork regression test. Forks became logical readers in moq-dev/moq#6024.moq-quic direction
qmux-credit*quests. Their credit and close requirements move intoquic-qmux.md, which moves from m2 to m1. The bug stays on main until that lands, and the release line gets no backport.ts-qmux: move@moq/qmuxintojs/.qmux-no-waitandquic-qmuxnow require it. Folding@moq/web-socket-streamin is recorded as a breaking change.native-noq-feature: drop moq-native's empty defaultnoqfeature.web-transport-iroh) andweb-transport-wasmare recorded as accepted exceptions.rs-request-credit,wire-stats/qmux(which now requires quic-qmux),audit-depsanddrop-web-transport-trait.noq-socket-closetoquic-socket-close, because the work is in-tree.Public API: none. Wire: none. Quest files only.
quest checkpasses.Decisions
Round 1
Round 2
Round 3
Review: the QUIC epic and
group-resetnow reflect qmux's move to m1, and whichever ofgroup-resetandquic-qmuxlands second implements qmux's offset reset. moq-uring'shost_tracks_moq_clockwas dropped, since moq-dev/moq#6056 already fixed it.Follow-ups
None beyond the quests planned here.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code