Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Continue PuppetControl's visually verified new-character animation work. This is an intentionally opt-in sharp-switch experiment, not a promise that all illustrated eyelids now deform smoothly. Stacked on draft PR #12 (
fix/verified-render-inputs), which depends on #11/#10/#9; do not merge directly to main.Changes
steppedDrawnEyestransform for Rev2D imported single-image characters with both reviewed closed/half eye drawings. Reuses short-fade topology validation, keeps non-eye controls unchanged.character variants import <project> eyes_closed eyes_half --experimental-stepped-eyes --reviewed-artoption; mutually exclusive with--experimental-short-fade. Both experimental variants remain opt-in and revoke character approval before any rig mutation; rebuilt review sheets, validation and exact build hashes follow.EyeOpen=0.195, half from0.195to0.69, and original mesh above0.69. Use a finite0.0001switch ramp to satisfy renderer constraints. No new engine, source image generation, or unreviewed asset approval.Actual A/B visual evidence
EyeOpen=0.69the pale translucent duplicate iris/eyelash is absent under the stepped profile. At0.19the closed eye no longer displays the ghosted underlying iris..cache/avatar-onboarding/stepped-eyes-20261107accepted both reviewed-art mask edits with zero outside-mask differences and kept approved:false. A separate QA-only copied character with temporary forced approval rendered a 45-frame 3-second 512x640 H.264 MP4 at 15 FPS, passed FFprobe and actual frames were visually inspected. The normal experimental character remains unapproved.Tests
npm run verify: 216 passing tests across 37 files, TypeScript typecheck/build green.git diff --checkclean, ignored QA files/rigs/audio not committed.Remaining blockers