Skip to content

feat: add opt-in stepped eyelid switches - #13

Draft
nkcbuilds wants to merge 1 commit into
fix/verified-render-inputsfrom
feat/eye-transition-no-ghost
Draft

nkcbuilds wants to merge 1 commit into
fix/verified-render-inputsfrom
feat/eye-transition-no-ghost

Conversation

@nkcbuilds

Copy link
Copy Markdown
Owner

Goal

Continue PuppetControl's visually verified new-character animation work. This is an intentionally opt-in sharp-switch experiment, not a promise that all illustrated eyelids now deform smoothly. Stacked on draft PR #12 (fix/verified-render-inputs), which depends on #11/#10/#9; do not merge directly to main.

Changes

  • Add pure guarded steppedDrawnEyes transform for Rev2D imported single-image characters with both reviewed closed/half eye drawings. Reuses short-fade topology validation, keeps non-eye controls unchanged.
  • New character variants import <project> eyes_closed eyes_half --experimental-stepped-eyes --reviewed-art option; mutually exclusive with --experimental-short-fade. Both experimental variants remain opt-in and revoke character approval before any rig mutation; rebuilt review sheets, validation and exact build hashes follow.
  • Derive opacity curves selecting closed below EyeOpen=0.195, half from 0.195 to 0.69, and original mesh above 0.69. Use a finite 0.0001 switch ramp to satisfy renderer constraints. No new engine, source image generation, or unreviewed asset approval.
  • Add unit/regression tests, detailed visual quality report, agent skill instructions, and a MIT-licensed Hana crop comparison with attribution in third-party notices.

Actual A/B visual evidence

Short fade (top) vs new stepped profile (bottom), four matching EyeOpen values

  • Real engine renders for 13 closing states mirrored into a 25-frame blink-review sequence, old vs stepped from the same refined imported Hana illustration.
  • At EyeOpen=0.69 the pale translucent duplicate iris/eyelash is absent under the stepped profile. At 0.19 the closed eye no longer displays the ghosted underlying iris.
  • Tradeoff fully acknowledged: ordered frame pixel-QA flagged 4 abrupt changes with stepped versus 0 with short fade, and 12 motion-stall candidates versus 10. Sharp changes and held sprite states remain visible; this is a stylized fallback, not seamless animation.
  • Separate mesh-only deform experiment rejected after visual inspection: near-closed eyes and iris were badly squeezed/distorted.
  • Live import into disposable .cache/avatar-onboarding/stepped-eyes-20261107 accepted both reviewed-art mask edits with zero outside-mask differences and kept approved:false. A separate QA-only copied character with temporary forced approval rendered a 45-frame 3-second 512x640 H.264 MP4 at 15 FPS, passed FFprobe and actual frames were visually inspected. The normal experimental character remains unapproved.

Tests

  • npm run verify: 216 passing tests across 37 files, TypeScript typecheck/build green.
  • Explicit mutual exclusion fails before modifying an existing approved character.
  • Stepped opacity completeness and one-visible-appearance checks for both eyes, no input mutation, bounded threshold behavior and unsupported topology rejection.
  • git diff --check clean, ignored QA files/rigs/audio not committed.

Remaining blockers

  • New closed/half drawings still have stiff lash contours. The stepped approach reduces alpha-ghosting but sacrifices continuous eyelid shape animation. Proper curved intermediate art or eyelid-specific continuous geometry remains required.
  • 25 ordered frames are a parameter-sweep test, not natural-timing/perceptual quality proof. More rights-cleared character styles and real speaking/blinking videos needed.
  • Keep this and upstream stacked PRs draft pending review, no automatic merging or art approval.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant