Canonicalize more comparison operators by mu001999 · Pull Request #165221 · rust-lang/rust

mu001999 · 2026-10-31T06:47:34Z

r? dianqk

rustbot · 2026-10-31T06:47:40Z

dianqk is currently at their maximum review capacity.
They may take a while to respond.

mu001999 · 2026-10-31T06:48:21Z

        StorageLive(_7);
        _7 = PtrMetadata(copy _1);
-        _8 = Le(copy _4, move _7);
+        _8 = Ge(move _7, copy _4);


This is because ReorderLocals

View changes since the review

rustbot · 2026-10-31T13:47:08Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

dianqk

LGTM. r=me
Please check whether the tests need to be blessed again.

View changes since this review

rustbot · 2026-11-12T15:00:19Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

dianqk · 2026-11-12T15:18:21Z

Can you reproduce tests/mir-opt/pre-codegen/slice_iter.range_loop.runtime-optimized.after.panic-abort.mir?

diff --git a/tests/mir-opt/pre-codegen/slice_iter.range_loop.runtime-optimized.after.panic-abort.mir b/tests/mir-opt/pre-codegen/slice_iter.range_loop.runtime-optimized.after.panic-abort.mir
index e817d9cd872..0fbeca458f4 100644
--- a/tests/mir-opt/pre-codegen/slice_iter.range_loop.runtime-optimized.after.panic-abort.mir
+++ b/tests/mir-opt/pre-codegen/slice_iter.range_loop.runtime-optimized.after.panic-abort.mir
@@ -56,7 +56,7 @@ fn range_loop(_1: &[T], _2: impl Fn(usize, &T)) -> () {
         StorageLive(_6);
         StorageLive(_5);
         _5 = copy _4;
-        _6 = Lt(move _5, copy _3);
+        _6 = Gt(copy _3, move _5);
         StorageDead(_5);
         switchInt(move _6) -> [0: bb2, otherwise: bb4];
     }
@@ -81,7 +81,7 @@ fn range_loop(_1: &[T], _2: impl Fn(usize, &T)) -> () {
         StorageLive(_9);
         _9 = copy ((_8 as Some).0: usize);
         StorageLive(_11);
-        _10 = Lt(copy _9, copy _3);
+        _10 = Gt(copy _3, copy _9);
         assert(move _10, "index out of bounds: the length is {} but the index is {}", copy _3, copy _9) -> [success: bb5, unwind unreachable];
     }

dianqk · 2026-11-12T21:51:40Z

@bors r+

rust-bors · 2026-11-12T21:51:43Z

📌 Commit 3406af2 has been approved by dianqk

It is now in the queue for this repository.

…-comparisons, r=dianqk Canonicalize more comparison operators As a follow-up PR to rust-lang#163373 (comment) r? dianqk

…uwer Rollup of 12 pull requests Successful merges: - #164707 (Re-enable rustc profile generation for static linked llvm on Windows x64 builds ) - #165221 (Canonicalize more comparison operators) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165861 (cg_llvm: Use an invariant lifetime brand for LLVM attributes) - #165872 (Some attribute related cleanups)

Zalathar · 2026-11-13T02:31:02Z

Possibly failed in rollup? Rollup of 12 pull requests #165891 (comment)

@bors r-
@bors try jobs=test-various

rust-bors · 2026-11-13T02:31:09Z

This pull request was unapproved.

This PR was contained in a rollup (#165891), which was unapproved.

View changes since this unapproval

…s, r=<try> Canonicalize more comparison operators try-job: test-various

rust-bors · 2026-11-13T03:18:18Z

💔 Test for 50de34e failed: CI. Failed job:

try - test-various (web logs, enhanced plaintext logs)

mu001999 · 2026-11-13T05:30:11Z

@bors try jobs=test-various

…s, r=<try> Canonicalize more comparison operators try-job: test-various

rust-bors · 2026-11-13T07:18:53Z

☀️ Try build successful (CI)
Build commit: a1e636e (a1e636e1547323956a7c64011b41ee233ba7a537)
Base parent: 8eb778d (8eb778d04094d3af4b26580cab327e0413eb1e02)

mu001999 · 2026-11-13T07:20:30Z

@bors r=dianqk

rust-bors · 2026-11-13T07:20:34Z

📌 Commit cac2cbf has been approved by dianqk

It is now in the queue for this repository.

…-comparisons, r=dianqk Canonicalize more comparison operators As a follow-up PR to rust-lang#163373 (comment) r? dianqk

…uwer Rollup of 18 pull requests Successful merges: - #164828 (When suggesting path of renamed crate, use the renamed name) - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch) - #165068 (Change color usage for highlights) - #165221 (Canonicalize more comparison operators) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165745 (Don't ICE when a guard condition is a place of type `!`) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) - #165905 (CI: Use a consistent locale when sorting docker build inputs)

…uwer Rollup of 17 pull requests Successful merges: - #164828 (When suggesting path of renamed crate, use the renamed name) - #164864 (Avoid hoisting uninitialized reads in EarlyOtherwiseBranch) - #165068 (Change color usage for highlights) - #165221 (Canonicalize more comparison operators) - #165841 (Tell Miri about the alignment handling in the Windows System allocator) - #165869 (Cleanup: Remove `path_matches` and `value_str` from `AttributeExt`) - #165880 (Remove dead code for returning `BackendRepr::Memory` with `PassMode::Direct`) - #164108 (Add unstable `-Zllvm-tpde` flag to `rustc_codegen_llvm`) - #165565 (view-types: lower view types from HIR) - #165622 (small cleanups in rustc_codegen_llvm) - #165771 (tests: cover MSVC ThinLTO exported symbol preservation) - #165810 (reflection: reflect attributes from adts, fields, and variants) - #165823 (Tweak crate error wording and turn them into fatal errors) - #165849 (More opt-dist improvements) - #165855 (Update `sysinfo` version to `0.40.3`) - #165872 (Some attribute related cleanups) - #165905 (CI: Use a consistent locale when sorting docker build inputs)

Rollup merge of #165221 - mu001999-contrib:canonicalize-more-comparisons, r=dianqk Canonicalize more comparison operators As a follow-up PR to #163373 (comment) r? dianqk

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 31, 2026

rustbot assigned dianqk Oct 31, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 31, 2026

mu001999 commented Oct 31, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

mu001999 force-pushed the canonicalize-more-comparisons branch from 2a9a24f to 700179f Compare October 31, 2026 07:38

mu001999 marked this pull request as ready for review October 31, 2026 13:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2026

dianqk approved these changes Nov 12, 2026

View reviewed changes

mu001999 force-pushed the canonicalize-more-comparisons branch from 700179f to fe65b69 Compare November 12, 2026 15:00

mu001999 force-pushed the canonicalize-more-comparisons branch from fe65b69 to 3406af2 Compare November 12, 2026 15:56

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2026

JonathanBrouwer mentioned this pull request Nov 12, 2026

Rollup of 12 pull requests #165891

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 13, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026

Auto merge of #165221 - mu001999-contrib:canonicalize-more-comparison…

50de34e

…s, r=<try> Canonicalize more comparison operators try-job: test-various

Zalathar mentioned this pull request Nov 13, 2026

Rollup of 13 pull requests #165897

Closed

This comment has been minimized.

Sign in to view

Canonicalize more comparison operators

cac2cbf

mu001999 force-pushed the canonicalize-more-comparisons branch from 3406af2 to cac2cbf Compare November 13, 2026 05:29

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026

Auto merge of #165221 - mu001999-contrib:canonicalize-more-comparison…

a1e636e

…s, r=<try> Canonicalize more comparison operators try-job: test-various

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2026

JonathanBrouwer mentioned this pull request Nov 13, 2026

Rollup of 18 pull requests #165908

Closed

JonathanBrouwer mentioned this pull request Nov 13, 2026

Rollup of 17 pull requests #165918

Merged

rust-bors Bot merged commit 1c0d284 into rust-lang:main Nov 13, 2026
15 checks passed

rustbot added this to the 1.102.0 milestone Nov 13, 2026

Conversation

mu001999 commented Oct 31, 2026

Uh oh!

rustbot commented Oct 31, 2026

Uh oh!

mu001999 Oct 31, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Oct 31, 2026

Uh oh!

dianqk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Nov 12, 2026

Uh oh!

dianqk commented Nov 12, 2026

Uh oh!

dianqk commented Nov 12, 2026

Uh oh!

rust-bors Bot commented Nov 12, 2026

Uh oh!

Zalathar commented Nov 13, 2026

Uh oh!

rust-bors Bot commented Nov 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 13, 2026

Uh oh!

This comment has been minimized.

mu001999 commented Nov 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 13, 2026

Uh oh!

mu001999 commented Nov 13, 2026

Uh oh!

rust-bors Bot commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mu001999 Oct 31, 2026 •

edited by rustbot

Loading

dianqk left a comment •

edited by rustbot

Loading