Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Address the four independent filesystem/path integrity findings documented against draft PR #10 without claiming a hostile multiuser security boundary. This is a draft stacked PR on
feat/actor-look-envelopes(#11), which depends on #10 and #9. It must not be merged into main without reviewing the stack.Fixes
verified-actor-assets/copy of source/spec/rig/texture files. Compare every copied file's SHA-256 withavatar-build.jsonand have Rev2D render from the copies, not the original paths. Model texture references must match the record.audio bindparses and hashes the same cue bytes. Bound scene rendering creates a freshverified-speech/copy of the voice and cues, hashes both against the previously verified sidecar and parses the copied cue JSON. FFmpeg receives the copied WAV path, not the original. Legacy unbound audio is still supported and has no such exact-byte guarantee.frame_0000.png-style names from the external Rev2D process.options.rootbypass:loadAndValidateScenechecks its scene, actor, audio, cues and binding paths against the same supplied realpath-aware root; invalid scoped paths produce diagnostics rather than unexpected exceptions.Full behavior and explicit threat-model limitations:
docs/RENDER_INTEGRITY.md.Validation
npm run verify: 211 tests passed across 36 files; TypeScript typecheck and build passed..cache/render-snapshot-qa-20261107-1800/qa-snapshot.mp4, 45 frames, 15 FPS, 512×640, H.264 using snapshotted model/textures. This does NOT mean the input artwork passed visual review..cache/first-video-demo/qa-12s-voiced/verified-snapshot-3s.mp4, 45 frames, 15 FPS, 512×640, H.264/AAC. FFmpeg's reported input is now.../verified-speech/voice.wav.git diff --checkclean.Remaining scope boundaries
These changes protect against ordinary accidental/replacement races, but they are not a sandbox against a malicious process with write access to the same render directory. Node, Rev2D and FFmpeg do not maintain pinned read-only file descriptors across every subprocess read. Unbound legacy audio does not receive exact-byte snapshotting. Both limits are stated plainly in the docs.
Animation quality (flat-PNG half-eye sprites, ghosting and cross-rig body bridges) remains independent and unresolved. Do not auto-approve the experimental character or merge the draft stack automatically.