Repository navigation
Rollup of 22 pull requests - #165234
Rollup of 22 pull requests#165234
Conversation
When a format string is not a literal in the source, e.g. when it is
produced by `concat!`, the offsets of printf- and shell-style
specifiers are relative to the expanded string rather than to the
source. `check_foreign!` still used them to place a machine-applicable
suggestion, which could rewrite unrelated source text such as turning
`concat!` into `c{}cat!`, or ICE when the span landed inside a
multibyte character.
When the format string is not a source literal, explain the
translation in a note instead, e.g. "`%d` should be written as `{}`",
and don't emit the suggestion. For specifiers that cannot be
translated, point the note at the whole format string argument
instead of a span computed from those offsets; the output is the same
as before. The output for format strings written as literals is
unchanged.
These are always checked in attribute parsing
```
error: expected expression, found `let` statement
--> issue-87291.rs:2:5
|
2 | - let a = opt1.map(|_| {
| - ^^^
| |
| expected an expression after this
|
= note: only supported directly in conditions of `if` and `while` expressions
```
By updating backtrace, curl, stacker. Also update flate2 and miniz_oxide to avoid introducing a duplicate dependency.
fixup cranelift
This would allow more flexibility in how we implement getting randomness in Redox OS by only requiring changes to relibc and randd. In addition it reduces the amount of Redox specific code libstd uses.
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
…c_passes` to `rustc_attr_parsing`
…ross35 Add behavior tests for `Arc` and `Rc` See <rust-lang#141348 (comment)>. r? @tgross35
…-perf, r=notriddle rustdoc: Fix performance regression for private documented items Should help with rust-lang#161362. The idea is to not (doc) inline private reexports by default. That will save us a lot of `clean`ing for external items and for html pages generation. r? ghost
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 92b5b8c (parent) -> 5a2a795 (this PR) Test differencesShow 175 test diffsStage 1
Stage 2
Additionally, 129 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5a2a7952ae19ceb9ee1056291a6a3ea9a998d844 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (5a2a795): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -8.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.5%, secondary -55.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 484.843s -> 488.324s (0.72%) |
|
📌 Perf builds for each rolled up PR:
parent commit: 92b5b8c87c In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
|
@rust-timer triage all |
Running triage with 15 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#164851 dd2f985 Add behavior tests for
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (primary 1.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
1.7% | [1.7%, 1.7%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 1.7% | [1.7%, 1.7%] | 1 |
Binary size
This perf run didn't have relevant results for this metric.
#164989 9c3416d rustdoc: Fix performance regression for private documented items
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-1.1% | [-5.1%, -0.1%] | 7 |
| Improvements ✅ (secondary) |
-30.8% | [-59.8%, -1.7%] | 2 |
| All ❌✅ (primary) | -1.1% | [-5.1%, -0.1%] | 7 |
Max RSS (memory usage)
Results (secondary -3.3%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
1.9% | [1.9%, 1.9%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-8.5% | [-8.5%, -8.5%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
Results (primary -3.8%, secondary -55.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-3.8% | [-3.8%, -3.8%] | 1 |
| Improvements ✅ (secondary) |
-55.0% | [-55.0%, -55.0%] | 1 |
| All ❌✅ (primary) | -3.8% | [-3.8%, -3.8%] | 1 |
Binary size
This perf run didn't have relevant results for this metric.
#165079 bd935ff Remove GenericArgRef
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
0.2% | [0.2%, 0.2%] | 4 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.3%] | 7 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
-0.6% | [-1.3%, -0.2%] | 20 |
| All ❌✅ (primary) | -0.0% | [-0.2%, 0.2%] | 9 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#161781 0fdda31 Don't emit InlineAsm terminator if input operand is !.
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#162754 14ef1dd optimize large elements for slice rotating
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#163252 c0ff808 Remove windows-targets dependency from the root workspace
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (secondary 1.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
1.7% | [1.7%, 1.7%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#163839 b614c5b Fix the floating point clobbers of RISC-V clobber_abi
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (secondary 3.3%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
3.3% | [3.3%, 3.3%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This perf run didn't have relevant results for this metric.
#165104 c9cf70b Use getrandom instead of /scheme/rand on Redox OS
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165132 6c301a7 Implement advance_back_by on Fuse
Queued 6c301a7 with parent 92b5b8c, future comparison URL.
There are currently 8 preceding artifacts in the queue.
It will probably take at least ~1.8 hours until the benchmark run finishes.
#165142 c2571d6 Remove the unused generic Graphviz writer
Queued c2571d6 with parent 92b5b8c, future comparison URL.
There are currently 9 preceding artifacts in the queue.
It will probably take at least ~2.0 hours until the benchmark run finishes.
#165233 1c05c27 Remove test-aarch64-apple-* jobs temporarily
Queued 1c05c27 with parent 92b5b8c, future comparison URL.
There are currently 10 preceding artifacts in the queue.
It will probably take at least ~2.2 hours until the benchmark run finishes.
#163371 b9117b6 Don't suggest replacing foreign format specifiers in concat! output
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.3%] | 5 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
Results (secondary 1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
1.9% | [1.9%, 1.9%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#163802 b47728e fix RegionEq direction in canonical query responses
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
-0.3% | [-0.4%, -0.3%] | 3 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#163986 eba0517 omit unconditionally invoking crate level limits query
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (primary 2.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
2.0% | [2.0%, 2.0%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 2.0% | [2.0%, 2.0%] | 1 |
Binary size
This perf run didn't have relevant results for this metric.
#164920 1b090c9 Point at prior token on let when expression is expected
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (secondary 3.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
3.7% | [3.7%, 3.7%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This perf run didn't have relevant results for this metric.
#164987 8465957 use adt_async_drop_tys for nested ADTs in needs_async_drop
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.2%] | 2 |
| Improvements ✅ (secondary) |
-0.3% | [-0.5%, -0.2%] | 3 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 2 |
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165061 23ecbc8 Use a fixed-length encoding for hash disambiguators in v0 symbols
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
This perf run didn't have relevant results for this metric.
Cycles
Results (primary 2.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
2.2% | [2.2%, 2.2%] | 1 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | 2.2% | [2.2%, 2.2%] | 1 |
Binary size
This perf run didn't have relevant results for this metric.
#165114 22c2a74 use native interpreter impl for funnel shifts intrinsics
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.2% | [0.2%, 0.2%] | 4 |
| Improvements ✅ (primary) |
-0.2% | [-0.2%, -0.1%] | 5 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 5 |
Max RSS (memory usage)
Results (secondary 1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
1.9% | [1.9%, 1.9%] | 1 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#165119 be30cbb remove unnecessary fast path from borrowck
Queued be30cbb with parent 92b5b8c, future comparison URL.
There are currently 15 preceding artifacts in the queue.
It will probably take at least ~3.2 hours until the benchmark run finishes.
#165122 1456217 fix MaybeDangling validity logic for ZST at usize::MAX
Queued 1456217 with parent 92b5b8c, future comparison URL.
There are currently 16 preceding artifacts in the queue.
It will probably take at least ~3.4 hours until the benchmark run finishes.
#165128 e8611ee Move doc(keyword) and doc(attribute) attributes checks from rustc_passes to rustc_attr_parsing
Queued e8611ee with parent 92b5b8c, future comparison URL.
There are currently 17 preceding artifacts in the queue.
It will probably take at least ~3.6 hours until the benchmark run finishes.
#165129 67c3d9d Fix ICE in prelude edition lint
Queued 67c3d9d with parent 92b5b8c, future comparison URL.
There are currently 18 preceding artifacts in the queue.
It will probably take at least ~3.8 hours until the benchmark run finishes.
Successful merges:
ArcandRc#164851 (Add behavior tests forArcandRc)!. #161781 (Don't emit InlineAsm terminator if input operand is!.)clobber_abi#163839 (Fix the floating point clobbers of RISC-Vclobber_abi)advance_back_byonFuse#165132 (Implementadvance_back_byonFuse)concat!output #163371 (Don't suggest replacing foreign format specifiers inconcat!output)letwhen expression is expected #164920 (Point at prior token onletwhen expression is expected)doc(keyword)anddoc(attribute)attributes checks fromrustc_passestorustc_attr_parsing#165128 (Movedoc(keyword)anddoc(attribute)attributes checks fromrustc_passestorustc_attr_parsing)Warning
This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup