Skip to content

feat: reviewable character look-motion limits - #11

Draft
nkcbuilds wants to merge 1 commit into
feat/character-review-gatesfrom
feat/actor-look-envelopes
Draft

nkcbuilds wants to merge 1 commit into
feat/character-review-gatesfrom
feat/actor-look-envelopes

Conversation

@nkcbuilds

Copy link
Copy Markdown
Owner

Purpose

Continue PuppetControl's reviewed-character animation work without claiming universal one-click PNG rigging. This is a draft stacked PR targeting feat/character-review-gates (draft PR #10), which itself depends on draft PR #9. Do not merge directly into main until the stack and visual findings are reviewed.

Changes

  • Imported single-image characters now start with restrained semantic look amplitudes: head yaw ±8°, head pitch ±5°, iris travel ±0.2 on each axis. New character build manifests explicitly record this under render.lookLimits.
  • Legacy provenance-tracked imported characters without lookLimits use a conservative fallback. Already-layered/upstream pre-rigged characters without lookLimits retain their existing ±22°/±12°/±0.5/±0.5 mapping, preserving those character styles.
  • Strict Zod validation accepts four independently configurable reduction-only bounds, including zero to disable a channel. Authoring invalid negative/oversized/missing fields fails before rendering.
  • Fix contradictory vertical look semantics: the scene uses +y down, Rev2D uses +y up, and both head pitch and iris motion now flip the scene Y so they follow the same intended direction.
  • character inspect displays effective limits and their source. Add docs/LOOK_MOTION.md and agent-facing guidance. Limits constrain amplitude only; never certify artistic quality.

Evidence

  • Imported unapproved Hana character.json and rig were compiled into real Rev2D controls with a full look event: AngleX=8, AngleY=-5, EyeBallX=0.2, EyeBallY=-0.2 (subject to final sign normalization), while its earlier manifest had no limit field.
  • Actual pinned Rev2D Hana imported rig was rendered separately at yaw 22°/8°, pitch 12°/5° and gaze 0.5/0.2, visually compared in ignored outputs/qa/look-envelope-20261107/look-comparison.jpg. Small positions stay recognizable; flat-art eyelids remain defective.
  • npm run verify: 192 tests over 32 files passed, typecheck and build green; git diff --check clean. Old defaults, imported fallback, independent authored amplitudes and invalid manifest cases are covered.

Known limitations / merge blockers

  • This changes the actual motion amplitude, not the source layers, eye art or physical head reconstruction. Hana remains approved:false.
  • PR feat: integrate character review and cue integrity gates #10 has independent audited path/asset integrity risks that need mitigation before the stack is declared ready; this PR stays draft until they are addressed and regressions validated.
  • User must visually review each actor's parameter sweep; a conservative bound is only a starting point.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nkcbuilds

Copy link
Copy Markdown
Owner Author

Follow-up real artwork QA (2026-11-07; locally ignored proof)

An independent visual worker built a separate, unapproved Hana eye-art refinement under .cache/avatar-onboarding/refined-eyes-20261107b/. The source art/rig in tracked files was not changed. Rev2D accepted both selected drawings with outside-mask difference = 0, closed-eye inside changed fraction = 0.4739, and half-eye = 0.2216.

A real 25-frame 30fps, 512x640 blink was rendered, with an old-vs-refined keyframe montage at outputs/qa/refined-eyes-20261107b/comparison-keyframes.png and refined/blink.mp4 (ignored local files, not redistributed). This appears materially cleaner at stable half/closed states: skin patch artifacts shrink, and most stray white/iris remnants disappear when fully closed. However, the authored lash still looks straight/mechanical, and the underlying sprite opacity interpolation still ghosts at EyeOpen≈0.69 and 0.19. The experiment remains approved:false and cannot establish arbitrary illustration quality.

Next true quality blocker: refine actual eyelid curvature and the engine's crossfade behavior with real intermediate art. Narrowing look amplitudes (#11) does not fix drawn eyelid or half↔closed overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant