Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Follow-up real artwork QA (2026-11-07; locally ignored proof)An independent visual worker built a separate, unapproved Hana eye-art refinement under A real 25-frame 30fps, 512x640 blink was rendered, with an old-vs-refined keyframe montage at Next true quality blocker: refine actual eyelid curvature and the engine's crossfade behavior with real intermediate art. Narrowing look amplitudes (#11) does not fix drawn eyelid or half↔closed overlap. |
Purpose
Continue PuppetControl's reviewed-character animation work without claiming universal one-click PNG rigging. This is a draft stacked PR targeting
feat/character-review-gates(draft PR #10), which itself depends on draft PR #9. Do not merge directly into main until the stack and visual findings are reviewed.Changes
lookamplitudes: head yaw ±8°, head pitch ±5°, iris travel ±0.2 on each axis. Newcharacter buildmanifests explicitly record this underrender.lookLimits.lookLimitsuse a conservative fallback. Already-layered/upstream pre-rigged characters withoutlookLimitsretain their existing ±22°/±12°/±0.5/±0.5 mapping, preserving those character styles.looksemantics: the scene uses +y down, Rev2D uses +y up, and both head pitch and iris motion now flip the scene Y so they follow the same intended direction.character inspectdisplays effective limits and their source. Adddocs/LOOK_MOTION.mdand agent-facing guidance. Limits constrain amplitude only; never certify artistic quality.Evidence
character.jsonand rig were compiled into real Rev2D controls with a fulllookevent:AngleX=8, AngleY=-5, EyeBallX=0.2, EyeBallY=-0.2(subject to final sign normalization), while its earlier manifest had no limit field.outputs/qa/look-envelope-20261107/look-comparison.jpg. Small positions stay recognizable; flat-art eyelids remain defective.npm run verify: 192 tests over 32 files passed, typecheck and build green;git diff --checkclean. Old defaults, imported fallback, independent authored amplitudes and invalid manifest cases are covered.Known limitations / merge blockers