Skip to content

test(net): update SUBSCRIBE_DROP fixture for ServeLoop framing - #6223

Merged
kixelated merged 2 commits into
mainfrom
codex/fix-serve-loop-test-fixture
Oct 22, 2026
Merged

kixelated merged 2 commits into
mainfrom
codex/fix-serve-loop-test-fixture

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The SUBSCRIBE_DROP regression fixture still passes a fourth timescale argument to ServeLoop::new after #6107 moved framing into track info. Every moq-net lib-test build fails with E0061, blocking Rust test validation across the active quest batch.

Approach

Remove the obsolete argument. Keep Info::timed(), which already sets Timescale::MILLI, preserving the fixture's millisecond timing and its lite-05/06/07 DROP error assertions.

Impact

  • Consumer: the existing a_subscribe_drop_ends_an_arriving_group_with_its_code test and Rust checks that compile moq-net lib tests.
  • No production code, public API, CLI, or wire-format change.

Validation

  • Reproduced E0061 on main at e76b4b32f3 with the targeted nextest command.
  • just rs test -p moq-net --lib -E 'test(a_subscribe_drop_ends_an_arriving_group_with_its_code)' now passes, including all three protocol versions.
  • just ci passed the Rust lint/docs stages and reached Nix flake checks. The unchanged runner-image build fails at systemd-repart with unshare: write failed /proc/self/uid_map: Operation not permitted. The complete gate still needs a host that permits that build.

Alternatives

Changing the constructor or introducing another test would add no value: the existing regression directly compiles and exercises the corrected call.

Follow-ups

No source follow-up. Keep draft until the complete gate can run on a suitable host. This enabling repair does not count as a quest in the requested batch.

(Written by GPT-6)

Co-Authored-By: GPT-6 <noreply@openai.com>
kixelated added a commit that referenced this pull request Oct 22, 2026
…fixture

Same one-line fix as #6223; main's moq-net lib tests fail to compile without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated added a commit that referenced this pull request Oct 22, 2026
Resolve rs/moq-mux/src/source.rs: the epoch-checked Binding from main now
binds through the watch-then-request Lookup. Keep both MIGRATE entries.
Pass the new epoch argument in the moq-hls sibling test, and drop the
stale Timescale argument from main's SUBSCRIBE_DROP fixture (same fix as
#6223) so moq-net tests compile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 00:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T00:29:19.380156Z c395b5d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 16f810e6-1bcf-40c5-9adb-b01154bab497
📥 Commits

Reviewing files that changed from the base of the PR and between 8a6eeb9 and c395b5d.

📒 Files selected for processing: 1
  • rs/moq-net/src/lite/subscriber.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged origin/main into the branch (no rebase) as c395b5df4cd82a273d82ba6752e5bef01013470c.

  • cargo test -p moq-net --lib --no-run fails with E0061 on main at 8a6eeb913f and passes on this head.
  • a_subscribe_drop_ends_an_arriving_group_with_its_code passes; cargo clippy -p moq-net --tests -- -D warnings is clean.
  • Codex review of c395b5d completed with no findings.

Enqueued with jump: true: a tests-only fix that unblocks every queued PR touching moq-net.

(Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant