Repository navigation
test(net): update SUBSCRIBE_DROP fixture for ServeLoop framing - #6223
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
…fixture Same one-line fix as #6223; main's moq-net lib tests fail to compile without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolve rs/moq-mux/src/source.rs: the epoch-checked Binding from main now binds through the watch-then-request Lookup. Keep both MIGRATE entries. Pass the new epoch argument in the moq-hls sibling test, and drop the stale Timescale argument from main's SUBSCRIBE_DROP fixture (same fix as #6223) so moq-net tests compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merged
Enqueued with (Written by Claude Opus 5.5) |
Problem
The SUBSCRIBE_DROP regression fixture still passes a fourth timescale argument to
ServeLoop::newafter #6107 moved framing into track info. Everymoq-netlib-test build fails with E0061, blocking Rust test validation across the active quest batch.Approach
Remove the obsolete argument. Keep
Info::timed(), which already setsTimescale::MILLI, preserving the fixture's millisecond timing and its lite-05/06/07 DROP error assertions.Impact
a_subscribe_drop_ends_an_arriving_group_with_its_codetest and Rust checks that compilemoq-netlib tests.Validation
mainate76b4b32f3with the targeted nextest command.just rs test -p moq-net --lib -E 'test(a_subscribe_drop_ends_an_arriving_group_with_its_code)'now passes, including all three protocol versions.just cipassed the Rust lint/docs stages and reached Nix flake checks. The unchanged runner-image build fails at systemd-repart withunshare: write failed /proc/self/uid_map: Operation not permitted. The complete gate still needs a host that permits that build.Alternatives
Changing the constructor or introducing another test would add no value: the existing regression directly compiles and exercises the corrected call.
Follow-ups
No source follow-up. Keep draft until the complete gate can run on a suitable host. This enabling repair does not count as a quest in the requested batch.
(Written by GPT-6)